linux-kernel - Re: [PATCH v2] usb: core: warn if a GFP zone flag is passed to hcd_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409174036.7ee76248@meshulam.tesarici.cz>
Date: Wed, 9 Apr 2025 17:40:36 +0200
From: Petr Tesařík <petr@...arici.cz>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Petr Tesarik <ptesarik@...e.com>, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: core: warn if a GFP zone flag is passed to
 hcd_buffer_alloc()

On Tue, 25 Mar 2025 14:40:00 +0100
Petr Tesarik <ptesarik@...e.com> wrote:

> Remove a misleading comment and issue a warning if a zone modifier is
> specified when allocating a hcd buffer.
> 
> There is no valid use case for a GFP zone modifier in hcd_buffer_alloc():
> - PIO mode can use any kernel-addressable memory
> - dma_alloc_coherent() ignores memory zone bits
> 
> This function is called by usb_alloc_coherent() and indirectly by
> usb_submit_urb(). Despite the comment, no in-tree users currently pass
> GFP_DMA.
> 
> Signed-off-by: Petr Tesarik <ptesarik@...e.com>

I know this was posted during the merge window, but that's now over.
Any comment on this patch?

Petr T