linux-kernel - Re: [PATCH 02/10] [v2] clocksource: atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ec655d05-f56c-4ee1-a26c-53d0207dc559@app.fastmail.com>
Date: Wed, 09 Apr 2025 17:53:27 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Daniel Lezcano" <daniel.lezcano@...aro.org>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
 "Nicolas Ferre" <nicolas.ferre@...rochip.com>,
 "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
 "Claudiu Beznea" <claudiu.beznea@...on.dev>,
 "Sergio Paracuellos" <sergio.paracuellos@...il.com>,
 "Markus Stockhausen" <markus.stockhausen@....de>,
 "Chris Packham" <chris.packham@...iedtelesis.co.nz>,
 "Mark Brown" <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] [v2] clocksource: atmel_tcb: fix kconfig dependency

On Wed, Apr 9, 2025, at 17:30, Andy Shevchenko wrote:
> On Wed, Apr 09, 2025 at 02:22:54PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> Build-testing this driver on arm without CONFIG_OF produces a warning:
>> 
>> drivers/clocksource/timer-atmel-tcb.c:368:34: error: 'atmel_tcb_of_match' defined but not used [-Werror=unused-const-variable=]
>>   368 | static const struct of_device_id atmel_tcb_of_match[] = {
>>       |                                  ^~~~~~~~~~~~~~~~~~
>> 
>> Change the dependency to allow build-testing on all architectures but
>> instead require CONFIG_OF to be present.
>
> I;m a bit puzzled, maybe due to my misunderstanding of the first line...
>
>>  config ATMEL_TCB_CLKSRC
>>  	bool "Atmel TC Block timer driver" if COMPILE_TEST
>
> ...^^^ of the dependencies.
>
>> -	depends on ARM && HAS_IOMEM
>> -	select TIMER_OF if OF
>> +	depends on ARM && OF && HAS_IOMEM
>
> But doesn't this still mean that "all architectures" (from the commit message)
> do not apply here (it's all about ARM)?

You are right, my mistake:

v1 of the patch allowed building on all architectures, but that
turned out to run into other bugs, so I changed the contents but
forgot to change the changelog.

I've sent a v3 patch now.

      Arnd