linux-kernel - Re: [PATCH v1 01/18] staging: gpib: struct typing for gpib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_az87Yx-NJvGASJ@tiamat>
Date: Wed, 9 Apr 2025 17:52:51 +0000
From: Michael Rubin <matchstick@...erthere.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: gregkh@...uxfoundation.org, dpenkler@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 01/18] staging: gpib: struct typing for gpib_interface

On Wed, Apr 09, 2025 at 11:26:41AM +0300, Dan Carpenter wrote:
> On Tue, Apr 08, 2025 at 10:24:47PM +0000, Michael Rubin wrote:
> > Using Linux code style for gpib_interface struct in .h to allow drivers to
> > migrate.
> > 
> > Adhering to Linux code style.
> > 
> > In general, a pointer, or a struct that has elements that can reasonably be
> > directly accessed should never be a typedef.
> > 
> > Reported by CheckPatch
> > 
> > WARNING: do not add new typedefs
> > 
> 
> This commit message is quite long but it's totally unrelated to what the
> patch does.
> 
> This commit message should just say "Having the word "_struct" in the
> name of the struct doesn't add any information so rename struct
> gpib_interface_struct to struct gpib_interface."

Thank you for the input. New commit marked v2 sent to the list.

Michael Rubin