linux-kernel - Re: [PATCH RESEND RFC v4 3/6] drm/display: dp: use new DCPD access helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf7bfe6f-69d7-4166-b3c4-010f7b9f3113@ijzerbout.nl>
Date: Wed, 9 Apr 2025 20:27:56 +0200
From: Kees Bakker <kees@...erbout.nl>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Lyude Paul <lyude@...hat.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Sean Paul <sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>,
 Jani Nikula <jani.nikula@...ux.intel.com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Xinliang Liu <xinliang.liu@...aro.org>, Tian Tao <tiantao6@...ilicon.com>,
 Xinwei Kong <kong.kongxinwei@...ilicon.com>,
 Sumit Semwal <sumit.semwal@...aro.org>, Yongqin Liu
 <yongqin.liu@...aro.org>, John Stultz <jstultz@...gle.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 amd-gfx@...ts.freedesktop.org, Dmitry Baryshkov
 <dmitry.baryshkov@...aro.org>, Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH RESEND RFC v4 3/6] drm/display: dp: use new DCPD access
 helpers

Op 24-03-2025 om 12:51 schreef Dmitry Baryshkov:
> From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
> Switch drm_dp_helper.c to use new set of DPCD read / write helpers.
>
> Reviewed-by: Lyude Paul <lyude@...hat.com>
> Acked-by: Jani Nikula <jani.nikula@...el.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>   drivers/gpu/drm/display/drm_dp_helper.c | 296 +++++++++++++-------------------
>   1 file changed, 116 insertions(+), 180 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index 410be0be233ad94702af423262a7d98e21afbfeb..e2439c8a7fefe116b04aaa689b557e2387b05540 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> [...]
> @@ -3542,7 +3509,7 @@ int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *aux, int max_frl_mask,
>   	else
>   		buf &= ~DP_PCON_FRL_LINK_TRAIN_EXTENDED;
>   
> -	ret = drm_dp_dpcd_writeb(aux, DP_PCON_HDMI_LINK_CONFIG_2, buf);
> +	return drm_dp_dpcd_write_byte(aux, DP_PCON_HDMI_LINK_CONFIG_2, buf);
>   	if (ret < 0)
>   		return ret;
>   
Don't forget to delete the remainder of the function.
Also the variable `ret` isn't used anymore.
-- 
Kees