linux-kernel - Re: [PATCH next] spi: spi_amd: Fix an IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93e6ae6d-0573-4475-b004-52dd24906ff0@quicinc.com>
Date: Thu, 10 Apr 2025 00:14:25 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
        Raju Rangoju
	<Raju.Rangoju@....com>
CC: Mark Brown <broonie@...nel.org>,
        Akshata MukundShetty
	<akshata.mukundshetty@....com>,
        Krishnamoorthi M <krishnamoorthi.m@....com>,
        <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] spi: spi_amd: Fix an IS_ERR() vs NULL check in probe

Looks good to me.

On 4/9/2025 4:30 PM, Dan Carpenter wrote:
> The devm_ioremap() function returns NULL on error, it doesn't
> return error pointers.  Update the error checking to match.
> 
> Fixes: b644c2776652 ("spi: spi_amd: Add PCI-based driver for AMD HID2 SPI controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/spi/spi-amd-pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-amd-pci.c b/drivers/spi/spi-amd-pci.c
> index e1ecab755fe9..e5faab414c17 100644
> --- a/drivers/spi/spi-amd-pci.c
> +++ b/drivers/spi/spi-amd-pci.c
> @@ -46,8 +46,8 @@ static int amd_spi_pci_probe(struct pci_dev *pdev,
>   	io_base_addr = (io_base_addr & AMD_SPI_BASE_ADDR_MASK) + AMD_HID2_PCI_BAR_OFFSET;
>   	amd_spi->io_remap_addr = devm_ioremap(dev, io_base_addr, AMD_HID2_MEM_SIZE);
>   
> -	if (IS_ERR(amd_spi->io_remap_addr))
> -		return dev_err_probe(dev, PTR_ERR(amd_spi->io_remap_addr),
> +	if (!amd_spi->io_remap_addr)
> +		return dev_err_probe(dev, -ENOMEM,
>   				"ioremap of SPI registers failed\n");
>   
>   	dev_dbg(dev, "io_remap_address: %p\n", amd_spi->io_remap_addr);
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>