linux-kernel - Re: [PATCH v4] octeontx2-pf: Add error log forcn10k_map_unmap_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409191828.GS395307@horms.kernel.org>
Date: Wed, 9 Apr 2025 20:18:28 +0100
From: Simon Horman <horms@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	hkelam@...vell.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] octeontx2-pf: Add error log
 forcn10k_map_unmap_rq_policer()

On Tue, Apr 08, 2025 at 11:26:02AM +0800, Wentao Liang wrote:
> The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer()
> for each queue in a for loop without checking for any errors.
> 
> Check the return value of the cn10k_map_unmap_rq_policer() function during
> each loop, and report a warning if the function fails.
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
> v4: Add brackets for loop
> v3: Add failed queue number and error code to log.
> v2: Fix error code

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>