linux-kernel - Re: [PATCH v3 2/2] kbuild: rust: provide an option to inline C helpers into Rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mMJLNq8PctLwXX=QM6EtoqV7EOgwv62W9tgkWv1A=quw@mail.gmail.com>
Date: Wed, 9 Apr 2025 23:05:58 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Gary Guo <gary@...yguo.net>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
	Masahiro Yamada <masahiroy@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, 
	Andrew Morton <akpm@...ux-foundation.org>, Peter Zijlstra <peterz@...radead.org>, 
	Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>, 
	Tamir Duberstein <tamird@...il.com>, Christian Brauner <brauner@...nel.org>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dirk Behme <dirk.behme@...bosch.com>, Daniel Xu <dxu@...uu.xyz>, 
	"Steven Rostedt (Google)" <rostedt@...dmis.org>, FUJITA Tomonori <fujita.tomonori@...il.com>, 
	"Rob Herring (Arm)" <robh@...nel.org>, Matt Gilbride <mattgilbride@...gle.com>, 
	Paul Moore <paul@...l-moore.com>, Kees Cook <kees@...nel.org>, rust-for-linux@...r.kernel.org, 
	llvm@...ts.linux.dev, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] kbuild: rust: provide an option to inline C
 helpers into Rust

On Wed, Apr 9, 2025 at 10:41 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> In addition, from what we discussed in the call, it would be nice to
> have some performance numbers compared to not enabling it, as well as
> compared to cross-language LTO.
>
> It would also help to know which users out there need/want to have this.

A couple more points, if we end up landing this:

  - We discussed that we may want this behind `EXPERT`.

  - We should probably mention in the config description that using an
exact LLVM version is recommended even if matching just the major
"should" work.

    By the way, here is the link that we sometimes mentioned in the
past: https://doc.rust-lang.org/rustc/linker-plugin-lto.html#toolchain-compatibility

  - We may want to mention that one needs `llvm-link` and `llvm-as` in
the config description.

    It should not be a big deal, since they typically are available in
the usual `llvm` package of distributions (e.g. Fedora and Ubuntu),
and the kernel.org combined Rust+LLVM toolchains have them already
since June thanks to Nathan.

Cheers,
Miguel