linux-kernel - Re: [PATCH v13 1/3] dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB2262E17477166BBC1B62B2E9FEB42@MA0P287MB2262.INDP287.PROD.OUTLOOK.COM>
Date: Wed, 9 Apr 2025 13:49:40 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Jingbao Qiu <qiujingbao.dlmu@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Arnd Bergmann <arnd@...db.de>, Yangyu Chen <cyy@...self.name>,
 linux-kernel@...r.kernel.org,
 Alexander Sverdlin <alexander.sverdlin@...il.com>, sophgo@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: soc: sophgo: add RTC support for
 Sophgo CV1800 series

On 2025/4/8 7:34, Inochi Amaoto wrote:
> On Mon, Apr 07, 2025 at 07:29:37AM +0200, Alexander Sverdlin wrote:
>> Hi Inochi!
>>
>> On Mon, 2025-04-07 at 09:09 +0800, Inochi Amaoto wrote:
>>>> Add RTC devicetree binding for Sophgo CV1800 series SoC. The device is
>>>> called RTC, but contains control registers of other HW blocks in its
>>>> address space, most notably of Power-on-Reset (PoR) module, DW8051 IP
>>>> (MCU core), accompanying SRAM, hence putting it in SoC subsystem.
>>>>
>>> I think this is a mfd device, so why not moving this into mfd subsystem?
>> MFD is by far the most tricky subsystem to get into [1] ;-)
>> SOC looks much more realistic [2]
>>
>> [1] https://lore.kernel.org/all/20250306003211.GA8350@google.com/
>> [2] https://lore.kernel.org/all/20250303-loud-mauve-coyote-1eefbb@krzk-bin/
>>
> Cool, let's keep it.
>
> LGTM.
>
> Reviewed-by: Inochi Amaoto <inochiama@...il.com>

Hi, Inochi

I think you were not reviewing the latest version of this patchset. The 
latest version is v14 
@https://lore.kernel.org/linux-rtc/20250315224921.3627852-1-alexander.sverdlin@gmail.com/

Chen