linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: Add binding for PS5511 hub controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <edc3cc2b-20a9-4175-9434-184485ea345f@kernel.org>
Date: Wed, 9 Apr 2025 08:06:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pin-yen Lin <treapking@...omium.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Kaehlcke <mka@...omium.org>,
 linux-kernel@...r.kernel.org, Stephen Boyd <swboyd@...omium.org>,
 linux-usb@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add binding for PS5511 hub
 controller

On 08/04/2025 06:30, Pin-yen Lin wrote:
>>> +  peer-hub:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>> +    description:
>>> +      phandle to the peer hub on the controller.
>>> +
>>> +  ports:
>>> +    $ref: /schemas/graph.yaml#/properties/ports
>>
>> I don't understand why do you need OF graph here. Children are already
>> defined in patternProperties as usb-devices.
> 
> I would like to describe the connection between the hub and the USB
> connectors, which is similar to commit c44d9dab31d6a9 ("dt-bindings:
> usb: Add downstream facing ports to realtek binding").
> 
> I'm aware that Rob expects a usb-hub.yaml binding in [1]. Should I do that now?
Yes, please, two devices using common pattern is already enough to
create common schema.

Best regards,
Krzysztof