linux-kernel - Re: [PATCH 0/2] iio: dac: adi-axi-dac: fix for wrong bus read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be16ccddf508a6252d4927af258bd10c8ecfb575.camel@gmail.com>
Date: Wed, 09 Apr 2025 07:17:29 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Angelo Dureghello <adureghello@...libre.com>, Nuno Sa
 <nuno.sa@...log.com>,  Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>,  Jonathan Cameron
 <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, Andy Shevchenko
 <andy@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Jonathan
 Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH 0/2] iio: dac: adi-axi-dac: fix for wrong bus read

On Tue, 2025-04-08 at 22:48 +0200, Angelo Dureghello wrote:
> This patchset is intended to fix a random wrong chip ID read, or a
> scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The 
> bus "read" operation must always check for busy flag before reading.
> 
> First patch reorganizes a bit the busy-wait polling code, second patch
> fixes the wrong bus read occurence. 
> 
> NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be
> applied after the linked "ramp generator" patch.
> 
> Link:
> https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> Signed-off-by: Angelo Dureghello <adureghello@...libre.com>
> ---

Hi Angelo, patches look good but typically fixes should come first. The reason is
that we only want to backport fixes to stable branches and like this we depend on the
first patch. So first use the plain regmap_read_poll_timeout() before accessing the
bus and then add the helper...

- Nuno Sá