linux-kernel - Re: [PATCH v2 6/6] gpiolib: acpi: Deduplicate some code in __acpi_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_YiP91I9ojNnOi4@smile.fi.intel.com>
Date: Wed, 9 Apr 2025 10:31:11 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Kees Bakker <kees@...erbout.nl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Mika Westerberg <westeri@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v2 6/6] gpiolib: acpi: Deduplicate some code in
 __acpi_find_gpio()

On Tue, Apr 08, 2025 at 10:09:25PM +0200, Kees Bakker wrote:
> Op 03-04-2025 om 17:59 schreef Andy Shevchenko:

...

> Please, check the changes in this function again.
> `__acpi_find_gpio` doesn't fill `info` anymore. The callers of this function
> will continue with
> an uninitialized struct.

My gosh, you are so right! Now I'm puzzled of what I was tested...
Nevertheless, I will fix this ASAP today, test (and double test to
be sure it works), and push it.

-- 
With Best Regards,
Andy Shevchenko