linux-kernel - Re: [PATCH v3 06/14] x86: Physical address comparisons in fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xbzssgempeueehescnj2chlkpgmyvxnysg2cdik7b56i4sri2p@4qfniovr2kdm>
Date: Wed, 9 Apr 2025 09:49:39 +0200
From: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
To: Dave Hansen <dave.hansen@...el.com>
CC: <hpa@...or.com>, <hch@...radead.org>, <nick.desaulniers+lkml@...il.com>,
	<kuan-ying.lee@...onical.com>, <masahiroy@...nel.org>,
	<samuel.holland@...ive.com>, <mingo@...hat.com>, <corbet@....net>,
	<ryabinin.a.a@...il.com>, <guoweikang.kernel@...il.com>,
	<jpoimboe@...nel.org>, <ardb@...nel.org>, <vincenzo.frascino@....com>,
	<glider@...gle.com>, <kirill.shutemov@...ux.intel.com>, <apopple@...dia.com>,
	<samitolvanen@...gle.com>, <kaleshsingh@...gle.com>, <jgross@...e.com>,
	<andreyknvl@...il.com>, <scott@...amperecomputing.com>,
	<tony.luck@...el.com>, <dvyukov@...gle.com>, <pasha.tatashin@...een.com>,
	<ziy@...dia.com>, <broonie@...nel.org>, <gatlin.newhouse@...il.com>,
	<jackmanb@...gle.com>, <wangkefeng.wang@...wei.com>,
	<thiago.bauermann@...aro.org>, <tglx@...utronix.de>, <kees@...nel.org>,
	<akpm@...ux-foundation.org>, <jason.andryuk@....com>, <snovitoll@...il.com>,
	<xin@...or.com>, <jan.kiszka@...mens.com>, <bp@...en8.de>, <rppt@...nel.org>,
	<peterz@...radead.org>, <pankaj.gupta@....com>, <thuth@...hat.com>,
	<andriy.shevchenko@...ux.intel.com>, <joel.granados@...nel.org>,
	<kbingham@...nel.org>, <nicolas@...sle.eu>, <mark.rutland@....com>,
	<surenb@...gle.com>, <catalin.marinas@....com>, <morbo@...gle.com>,
	<justinstitt@...gle.com>, <ubizjak@...il.com>, <jhubbard@...dia.com>,
	<urezki@...il.com>, <dave.hansen@...ux.intel.com>, <bhe@...hat.com>,
	<luto@...nel.org>, <baohua@...nel.org>, <nathan@...nel.org>,
	<will@...nel.org>, <brgerst@...il.com>, <llvm@...ts.linux.dev>,
	<linux-mm@...ck.org>, <linux-doc@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kbuild@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kasan-dev@...glegroups.com>,
	<x86@...nel.org>
Subject: Re: [PATCH v3 06/14] x86: Physical address comparisons in
 fill_p*d/pte

On 2025-04-04 at 09:56:31 -0700, Dave Hansen wrote:
>On 4/4/25 06:14, Maciej Wieczor-Retman wrote:
>> +		if (__pa(p4d) != (pgtable_l5_enabled() ?
>> +				  (unsigned long)pgd_val(*pgd) & PTE_PFN_MASK :
>> +				  __pa(pgd)))
>>  			printk(KERN_ERR "PAGETABLE BUG #00! %p <-> %p\n",
>
>This one is pretty fugly. But I guess it's just one place and it
>probably isn't worth refactoring this and the other helpers just for a
>debug message.

I was trying to think of some prettier way to open code it but this seemed like
the simplest one.

-- 
Kind regards
Maciej Wieczór-Retman