linux-kernel - Re: [PATCH v8 06/10] drm/sched: add the drm_client_id to the drm_sched_run/exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7103bc5d3212aa5068fbc6a39a53fae04b36e467.camel@mailbox.org>
Date: Wed, 09 Apr 2025 09:56:30 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>, 
 Matthew Brost <matthew.brost@...el.com>, Danilo Krummrich
 <dakr@...nel.org>, Philipp Stanner <phasta@...nel.org>,  Christian
 König <ckoenig.leichtzumerken@...il.com>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>,  Thomas Zimmermann <tzimmermann@...e.de>, David
 Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: Christian König <christian.koenig@....com>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 06/10] drm/sched: add the drm_client_id to the
 drm_sched_run/exec_job events

On Thu, 2025-03-20 at 10:58 +0100, Pierre-Eric Pelloux-Prayer wrote:
> For processes with multiple drm_file instances, the drm_client_id is
> the only way to map jobs back to their unique owner.
> 
> It's even more useful if drm client_name is set, because now a tool
> can map jobs to the client name instead of only having access to
> the process name.
> 
> Reviewed-by: Christian König <christian.koenig@....com>
> Signed-off-by: Pierre-Eric Pelloux-Prayer

Acked-by: Philipp Stanner <phasta@...nel.org>

> <pierre-eric.pelloux-prayer@....com>
> ---
>  drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> index 5d9992ad47d3..38cdd659a286 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> @@ -43,6 +43,7 @@ DECLARE_EVENT_CLASS(drm_sched_job,
>  			     __string(dev, dev_name(sched_job-
> >sched->dev))
>  			     __field(u64, fence_context)
>  			     __field(u64, fence_seqno)
> +			     __field(u64, client_id)
>  			     ),
>  
>  	    TP_fast_assign(
> @@ -54,11 +55,12 @@ DECLARE_EVENT_CLASS(drm_sched_job,
>  			   __assign_str(dev);
>  			   __entry->fence_context = sched_job-
> >s_fence->finished.context;
>  			   __entry->fence_seqno = sched_job-
> >s_fence->finished.seqno;
> +			   __entry->client_id = sched_job->s_fence-
> >drm_client_id;
>  			   ),
> -	    TP_printk("dev=%s, id=%llu, fence=%llu:%llu, ring=%s,
> job count:%u, hw job count:%d",
> +	    TP_printk("dev=%s, id=%llu, fence=%llu:%llu, ring=%s,
> job count:%u, hw job count:%d, client_id:%llu",
>  		      __get_str(dev), __entry->id,
>  		      __entry->fence_context, __entry->fence_seqno,
> __get_str(name),
> -		      __entry->job_count, __entry->hw_job_count)
> +		      __entry->job_count, __entry->hw_job_count,
> __entry->client_id)
>  );
>  
>  DEFINE_EVENT(drm_sched_job, drm_sched_job,