linux-kernel - Re: [PATCH] brcm80211: fmac: Add error check for brcmf_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cf4d7d5-e9f8-4c10-810b-5c7da72db1c8@web.de>
Date: Wed, 9 Apr 2025 10:16:34 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, brcm80211-dev-list.pdl@...adcom.com,
 brcm80211@...ts.linux.dev, linux-wireless@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Arend van Spriel <arend.vanspriel@...adcom.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 Kalle Valo <kvalo@...nel.org>, Ondřej Jirman <megi@....cz>,
 Sai Krishna <saikrishnag@...vell.com>
Subject: Re: [PATCH] brcm80211: fmac: Add error check for brcmf_usb_dlneeded()

…
> Add error handling for brcmf_usb_dl_cmd() to return the function if the
> 'id.chiprev' is uninitialized.

* Please reconsider the offered conclusion once more.

* I propose to replace the word “for” by “in” (before function names)
  in some summary phrases.


…
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
…
> @@ -798,7 +799,11 @@ brcmf_usb_dlneeded(struct brcmf_usbdev_info *devinfo)
>
>  	/* Check if firmware downloaded already by querying runtime ID */
>  	id.chip = cpu_to_le32(0xDEAD);
> -	brcmf_usb_dl_cmd(devinfo, DL_GETVER, &id, sizeof(id));
> +	err = brcmf_usb_dl_cmd(devinfo, DL_GETVER, &id, sizeof(id));
> +	if (err) {
> +		brcmf_err("DL_GETID Failed\n");
> +		return false;
> +	}
…

Would an error hint like “DL_GETVER failed\n” be more appropriate here?

Regards,
Markus