[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z/YxbXZ6Wp6q6kNn@dev-linux>
Date: Wed, 9 Apr 2025 01:35:57 -0700
From: Sukrut Bellary <sbellary@...libre.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Andreas Kemnade <andreas@...nade.info>,
Michael Turquette <mturquette@...libre.com>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
Stephen Boyd <sboyd@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Kevin Hilman <khilman@...libre.com>, linux-clk@...r.kernel.org,
Tero Kristo <kristo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: clock: ti: Convert to yaml
On Fri, Apr 04, 2025 at 09:56:01AM -0500, Rob Herring (Arm) wrote:
>
> On Thu, 03 Apr 2025 18:44:58 -0700, Sukrut Bellary wrote:
> > This binding doesn't define a new clock binding type,
> > it is used to group the existing clock nodes under the hardware hierarchy.
> >
> > As this is not a provider clock, remove #clock-cells and
> > clock-output-names properties.
> > Though few clockdomain nodes in the dts use these properties,
> > we are not fixing dts here.
> > Clean up the example to meet the current standards.
> >
> > Add the creator of the original binding as a maintainer.
> >
> > Signed-off-by: Sukrut Bellary <sbellary@...libre.com>
> > ---
> > .../bindings/clock/ti/clockdomain.txt | 25 ------------
> > .../bindings/clock/ti/ti,clockdomain.yaml | 38 +++++++++++++++++++
> > 2 files changed, 38 insertions(+), 25 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/clock/ti/clockdomain.txt
> > create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,clockdomain.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):
> Warning: Documentation/devicetree/bindings/clock/ti/fixed-factor-clock.txt references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/autoidle.txt
> Warning: Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/autoidle.txt
> Warning: Documentation/devicetree/bindings/clock/ti/ti,gate-clock.yaml references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/clockdomain.txt
> Warning: Documentation/translations/ja_JP/process/submit-checklist.rst references a file that doesn't exist: Documentation/translations/ja_JP/SubmitChecklist
> Documentation/devicetree/bindings/clock/ti/fixed-factor-clock.txt: Documentation/devicetree/bindings/clock/ti/autoidle.txt
> Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml: Documentation/devicetree/bindings/clock/ti/autoidle.txt
> Documentation/devicetree/bindings/clock/ti/ti,gate-clock.yaml: Documentation/devicetree/bindings/clock/ti/clockdomain.txt
> Documentation/translations/ja_JP/process/submit-checklist.rst: Documentation/translations/ja_JP/SubmitChecklist
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250404014500.2789830-3-sbellary@baylibre.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
OK, thanks.
I will check and re-submit.
Powered by blists - more mailing lists