linux-kernel - Re: [PATCH] brcm80211: fmac: Add error handling for brcmf_usb_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cd21e2c-0a28-4eff-9dba-e5a730aa5a92@web.de>
Date: Wed, 9 Apr 2025 10:36:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, brcm80211-dev-list.pdl@...adcom.com,
 brcm80211@...ts.linux.dev, linux-wireless@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Arend van Spriel <arend.vanspriel@...adcom.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 Kalle Valo <kvalo@...nel.org>, Ondřej Jirman <megi@....cz>,
 Sai Krishna <saikrishnag@...vell.com>
Subject: Re: [PATCH] brcm80211: fmac: Add error handling for
 brcmf_usb_dl_writeimage()

> The function brcmf_usb_dl_writeimage() calls the function
> brcmf_usb_dl_cmd() but dose not check its return value. The

* Wording suggestion:
  The brcmf_usb_dl_cmd() function is called here.
  Unfortunately, its return value was not checked so far.

* You may occasionally put more than 60 characters into text lines
  of such a change description.

* I propose to replace the word “for” by “in” (before function names)
  in some summary phrases.

Regards,
Markus