linux-kernel - Re: [PATCH v7 01/12] mtd: core: always create master device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfgpejtu.fsf@bootlin.com>
Date: Wed, 09 Apr 2025 11:59:57 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Usyskin, Alexander" <alexander.usyskin@...el.com>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  "De Marchi, Lucas" <lucas.demarchi@...el.com>,  Thomas
 Hellström <thomas.hellstrom@...ux.intel.com>,  "Vivi,
 Rodrigo"
 <rodrigo.vivi@...el.com>,  Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>,  Maxime Ripard <mripard@...nel.org>,
  Thomas Zimmermann <tzimmermann@...e.de>,  David Airlie
 <airlied@...il.com>,  Simona Vetter <simona@...ll.ch>,  Jani Nikula
 <jani.nikula@...ux.intel.com>,  Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>,  Tvrtko Ursulin <tursulin@...ulin.net>,
  "Poosa, Karthik" <karthik.poosa@...el.com>,  "Abliyev, Reuven"
 <reuven.abliyev@...el.com>,  "Weil, Oren jer" <oren.jer.weil@...el.com>,
  "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
  "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
  "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 01/12] mtd: core: always create master device

Hello,

> The mtd_master is completely different class to avoid mtd tree disturbances.
> It is real kernel device object, I'm not sure how we can do 'link to'
> magic here.

Maybe we can add that later if someone needs.

> About MTD_PARTITIONED_MASTER - we can treat it as another partition and 
> create master device plus whole device partition as it's child with all other
> partitions as children of master device.
> For unpartitioned device this mean that we create master device and partition
> regardless of MTD_PARTITIONED_MASTER flag.

I am not sure I follow you. I am proposing to create the mtd_master
device in all cases. I believe this is the future-proof approach. Can
you make this change?

Regarding the hierarchy, I indeed agree with what you propose:
mtd_master parent of whole partition device (if any) parent of
partitions.

Thanks,
Miquèl