linux-kernel - Re: [PATCH v6 4/4] x86/sev: register tpm-svsm platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409102120.GCZ_ZKIJw9WkXpTz4u@fat_crate.local>
Date: Wed, 9 Apr 2025 12:21:20 +0200
From: Borislav Petkov <bp@...en8.de>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
	"H. Peter Anvin" <hpa@...or.com>, linux-coco@...ts.linux.dev,
	linux-integrity@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	x86@...nel.org, Tom Lendacky <thomas.lendacky@....com>,
	Joerg Roedel <jroedel@...e.de>,
	Dionna Glaze <dionnaglaze@...gle.com>,
	Claudio Carvalho <cclaudio@...ux.ibm.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-kernel@...r.kernel.org, Dov Murik <dovmurik@...ux.ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v6 4/4] x86/sev: register tpm-svsm platform device

On Tue, Apr 08, 2025 at 01:54:07PM +0200, Stefano Garzarella wrote:
> I see, so IIUC I can just apply the following change to this patch and avoid
> to export snp_svsm_vtpm_probe() at all, right?
> 
> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index acbd9bc526b1..fa83e6c7f990 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -2702,8 +2702,10 @@ static int __init snp_init_platform_device(void)
>         if (platform_device_register(&sev_guest_device))
>                 return -ENODEV;
> -       if (platform_device_register(&tpm_svsm_device))
> -               return -ENODEV;
> +       if (snp_svsm_vtpm_probe()) {
> +               if (platform_device_register(&tpm_svsm_device))
> +                       return -ENODEV;
> +       }
>         pr_info("SNP guest platform device initialized.\n");
>         return 0;

No, this should go in tpm_svsm_probe().

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette