linux-kernel - Re: [PATCH v1 1/1] x86/early_printk: Fix comment for "pciserial" case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_ZL04J10YbsBaYz@gmail.com>
Date: Wed, 9 Apr 2025 12:28:35 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v1 1/1] x86/early_printk: Fix comment for "pciserial" case


* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> The comment seem contains the copy'n'paste error when mentioning "serial"
> instead of "pciserial" (with double quotes). Fix this. With that, move
> it upper, so we don't calculate buf twice.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  arch/x86/kernel/early_printk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
> index dc053641698c..4a9ba7cb7e5a 100644
> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -442,9 +442,9 @@ static int __init setup_early_printk(char *buf)
>  		}
>  #ifdef CONFIG_PCI
>  		if (!strncmp(buf, "pciserial", 9)) {
> -			early_pci_serial_init(buf + 9);
> +			buf += 9; /* Keep from match the above "pciserial" */
> +			early_pci_serial_init(buf);
>  			early_console_register(&early_serial_console, keep);
> -			buf += 9; /* Keep from match the above "serial" */

Note that I merged this into the other fix, in part because the title 
isn't accurate anymore, this patch isn't purely fixing the comment.

Thanks,

	Ingo