linux-kernel - Re: [PATCH] platform: cznic: use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfiE+XKCQ-6sZ1c1hgyDOJ2F9wFJ2VX9nXfZUp1n4=5kg@mail.gmail.com>
Date: Wed, 9 Apr 2025 13:03:57 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Marek Behún <marek.behun@....cz>
Cc: Marek Behún <kabel@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] platform: cznic: use new GPIO line value setter callbacks

On Wed, Apr 9, 2025 at 11:17 AM Marek Behún <marek.behun@....cz> wrote:
>
> On Tue, Apr 08, 2025 at 09:19:19AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> ...
>
> > -static void omnia_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
> > -                                 unsigned long *bits)
> > +static int omnia_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
> > +                                unsigned long *bits)
> >  {
> >       unsigned long ctl = 0, ctl_mask = 0, ext_ctl = 0, ext_ctl_mask = 0;
> >       struct omnia_mcu *mcu = gpiochip_get_data(gc);
> >       unsigned int i;
> > +     int ret;
>
> In this driver the name `err' is used everywhere for this kind of
> variable (when it contains error code or zero for success).
> `ret' is only used if the variable can also contain positive return
> value.
>
> Bartosz, I will send updated version, if that is okay with you?
>
> Marek

Sure, I can also do it myself if you prefer.

Bart