linux-kernel - Re: [PATCH v2 1/2] rust: retain pointer mut-ness in `container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87semhbncg.fsf@kernel.org>
Date: Wed, 09 Apr 2025 13:12:15 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Tamir Duberstein" <tamird@...il.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>,  "Alex Gaynor"
 <alex.gaynor@...il.com>,  "Boqun Feng" <boqun.feng@...il.com>,  "Gary Guo"
 <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  "Benno
 Lossin" <benno.lossin@...ton.me>,  "Alice Ryhl" <aliceryhl@...gle.com>,
  "Trevor Gross" <tmgross@...ch.edu>,  "Bjorn Helgaas"
 <bhelgaas@...gle.com>,  "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
  "Rafael J. Wysocki" <rafael@...nel.org>,  "Danilo Krummrich"
 <dakr@...nel.org>,  "Tejun Heo" <tj@...nel.org>,  "Lai Jiangshan"
 <jiangshanlai@...il.com>,  <rust-for-linux@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>,  <linux-pci@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] rust: retain pointer mut-ness in `container_of!`

"Tamir Duberstein" <tamird@...il.com> writes:

> Avoid casting the input pointer to `*const _`, allowing the output
> pointer to be `*mut` if the input is `*mut`. This allows a number of
> `*const` to `*mut` conversions to be removed at the cost of slightly
> worse ergonomics when the macro is used with a reference rather than a
> pointer; the only example of this was in the macro's own doctest.
>
> Reviewed-by: Benno Lossin <benno.lossin@...ton.me>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>

Reviewed-by: Andreas Hindborg <a.hindborg@...nel.org>

Best regards,
Andreas Hindborg