linux-kernel - Re: [PATCH v8 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3878cce7-1a85-7f87-70ac-722cfa9d3e19@inria.fr>
Date: Tue, 8 Apr 2025 22:11:56 -0400 (EDT)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Samuel Abraham <abrahamadekunle50@...il.com>
cc: Andy Shevchenko <andy@...nel.org>, outreachy@...ts.linux.dev, 
    gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, 
    linux-kernel@...r.kernel.org, david.laight.linux@...il.com, 
    dan.carpenter@...aro.org
Subject: Re: [PATCH v8 0/2] staging: rtl8723bs: Improve readability and
 clarity of sequence number wrapping



On Tue, 8 Apr 2025, Samuel Abraham wrote:

> On Tue, Apr 8, 2025 at 8:41 PM Andy Shevchenko <andy@...nel.org> wrote:
> >
> > On Tue, Apr 08, 2025 at 03:41:55PM +0000, Abraham Samuel Adekunle wrote:
> > > The patchset adds spaces around binary operators, breaks long lines to enhance readability
> > > and provides clarity on sequence number wrapping by using a modulo operation % 4096u, in
> > > place of the bitwise AND(&) operation & 0xfff.
> > > The patches are required to be applied in sequence.
> >
> > You missed my tags I gave in a previous review round.
>
> Oh, I'm sorry I do not know how that works, please.
> Am I supposed to add them to the commit message?

Yes.

julia

> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >
> >
>