linux-kernel - Re: [PATCH v2 1/2] staging: rtl8723bs: Improve code readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dd38b27ac15fe9d76e326e4f4c05d71a18b2154.camel@gmail.com>
Date: Wed, 09 Apr 2025 14:22:14 +0300
From: Erick Karanja <karanja99erick@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Julia Lawall
	 <julia.lawall@...ia.fr>
Cc: gregkh@...uxfoundation.org, outreachy@...ts.linux.dev, 
	philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: Improve code readability

On Wed, 2025-04-09 at 14:11 +0300, Dan Carpenter wrote:
> On Wed, Apr 09, 2025 at 07:04:18AM -0400, Julia Lawall wrote:
> > > @@ -729,10 +721,9 @@ static void hal_ReadEFuse_WiFi(
> > >  		}
> > > 
> > >  		if (offset < EFUSE_MAX_SECTION_8723B) {
> > > -			u16 addr;
> > > +			u16 addr = offset * PGPKT_DATA_SIZE;
> > >  			/*  Get word enable value from PG header
> > > */
> > > 
> > > -			addr = offset * PGPKT_DATA_SIZE;
> > 
> > I'm not sure about this one, due to the comment.
> > 
> > julia
> > 
> 
> I feel like it works.  I wish there were a blank line after the
> declaration but that's something for a different patch.  Both of
> these are okay with me.  Try to be more creative with the subjects
> next time.  (Just put the file name in the subject because that's
> the only difference).
Thank you for the review.
Erick
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> regards,
> dan carpenter
>