linux-kernel - Re: commit 7b025f3f85ed causes NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_ZeraOgM0d-WMus@black.fi.intel.com>
Date: Wed, 9 Apr 2025 14:49:01 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: Bert Karwatzki <spasswolf@....de>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-kernel@...r.kernel.org, James.Bottomley@...senpartnership.com,
	Jonathan.Cameron@...wei.com, allenbh@...il.com, d-gole@...com,
	dave.jiang@...el.com, haiyangz@...rosoft.com, jdmason@...zu.us,
	kristo@...nel.org, linux-hyperv@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-scsi@...r.kernel.org,
	logang@...tatee.com, manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com, maz@...nel.org, mhklinux@...look.com,
	nm@...com, ntb@...ts.linux.dev, peterz@...radead.org,
	ssantosh@...nel.org, wei.huang2@....com, wei.liu@...nel.org
Subject: Re: commit 7b025f3f85ed causes NULL pointer dereference

On Tue, Apr 08, 2025 at 10:46:12PM +0200, Thomas Gleixner wrote:
> On Tue, Apr 08 2025 at 18:20, Bert Karwatzki wrote:
> > Am Dienstag, dem 08.04.2025 um 17:29 +0200 schrieb Thomas Gleixner:
> >> > Can you please decode the lines please via:
> >> >
> >> >     scripts/faddr2line vmlinux msi_domain_first_desc+0x4/0x30
> >> >     scripts/faddr2line vmlinux msix_setup_interrupts+0x23b/0x280

Also hit this, bisected to this change and in my case it's Clang 19.

> > I had to recompile with CONFIG_DEBUG_INFO=Y, and reran the test, the calltrace
> > is identical.
> >
> > $ scripts/faddr2line vmlinux msi_domain_first_desc+0x4/0x30
> > msi_domain_first_desc+0x4/0x30:
> > msi_domain_first_desc at kernel/irq/msi.c:400
> >
> > So it seems msi_domain_first_desc() is called with dev = NULL.
> 
> Yup
> 
> > $ scripts/faddr2line vmlinux msix_setup_interrupts+0x23b/0x280
> > msix_setup_interrupts+0x23b/0x280:
> > msix_update_entries at drivers/pci/msi/msi.c:647 (discriminator 1)
> 
> Aaarg. The patch below should fix that.

Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko