linux-kernel - Re: crypto: sun8i-ce-hash - Refine exception handling in sun8i_ce_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e10ecbe1-d8c3-444d-92cb-647a1c54675f@web.de>
Date: Wed, 9 Apr 2025 14:46:28 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Andre Przywara <andre.przywara@....com>,
 Ovidiu Panait <ovidiu.panait.oss@...il.com>, linux-sunxi@...ts.linux.dev,
 linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc: Chen-Yu Tsai <wens@...e.org>, Corentin Labbe <clabbe.montjoie@...il.com>,
 "David S. Miller" <davem@...emloft.net>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, LKML <linux-kernel@...r.kernel.org>,
 Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: crypto: sun8i-ce-hash - Refine exception handling in
 sun8i_ce_hash_run()

>> Two if branches contained duplicate source code.
>> Thus avoid the specification of repeated error code assignments by using
>> additional labels instead.
…
> Now there is one rather opaque label it goes to, so a reader doesn't see
> the error code immediately. And it really just saves one line per case
> here. …
I imagine that such a code refinement can occasionally matter.

Regards,
Markus