linux-kernel - Re: [PATCH net-next v7 04/13] net: pse-pd: Add support for PSE power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409145848.552fadd2@kmaincent-XPS-13-7390>
Date: Wed, 9 Apr 2025 14:58:48 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Donald Hunter
 <donald.hunter@...il.com>, Rob Herring <robh@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Liam
 Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v7 04/13] net: pse-pd: Add support for PSE
 power domains

Hello Oleksij,

On Tue, 8 Apr 2025 20:09:36 +0200
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> Hi Kory,
> 
> here are some points
> 
> On Tue, Apr 08, 2025 at 04:32:13PM +0200, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > +static struct pse_power_domain *devm_pse_alloc_pw_d(struct device *dev)
> > +{
> > +	struct pse_power_domain *pw_d;
> > +	int index, ret;
> > +
> > +	pw_d = devm_kzalloc(dev, sizeof(*pw_d), GFP_KERNEL);
> > +	if (!pw_d)
> > +		return ERR_PTR(-ENOMEM);
> > +
> > +	ret = xa_alloc(&pse_pw_d_map, &index, pw_d, XA_LIMIT(1,
> > PSE_PW_D_LIMIT),
> > +		       GFP_KERNEL);
> > +	if (ret)
> > +		return ERR_PTR(ret);  
> 
> Missing "kref_init(&pw_d->refcnt);" ?

Oh yes, indeed thanks.

> > +
> > +		pw_d = devm_pse_alloc_pw_d(pcdev->dev);
> > +		if (IS_ERR_OR_NULL(pw_d)) {  
> 
> s/IS_ERR_OR_NULL/IS_ERR
> 
> devm_pse_alloc_pw_d() is not returning NULL.

Yes, that's right!

> > +			ret = PTR_ERR(pw_d);
> > +			goto out;
> > +		}
> > +
> > +		supply = regulator_get(&rdev->dev, rdev->supply_name);
> > +		if (IS_ERR(supply)) {
> > +			xa_erase(&pse_pw_d_map, pw_d->id);
> > +			ret = PTR_ERR(supply);  
> 
> Here:
> Either we need to ensure pse_flush_pw_ds() handles incomplete setups
> or immediately clean up earlier entries in the loop when an error
> occurs.

The pw_d has not yet been saved to pcdev->pi[i].pw_d so we need to remove the
pw_d from the xarray here. pse_flush_pw_ds will deal with all the pw_d entries
in pcdev->pi[x].

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com