linux-kernel - Re: [PATCH 1/1] cxl/feature: Update rpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a0c0846-1fad-4f46-a5d0-699d2407d266@zohomail.com>
Date: Wed, 9 Apr 2025 10:27:28 +0800
From: Li Ming <ming.li@...omail.com>
To: dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
 alison.schofield@...el.com, vishal.l.verma@...el.com, ira.weiny@...el.com,
 dan.j.williams@...el.com
Cc: linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] cxl/feature: Update rpc_out in set feature failure
 case

On 4/9/2025 10:12 AM, Li Ming wrote:
> CXL subsystem supports userspace to configure component features via
> fwctl interface, it will configure features by using Set Feature
> command. Whatever Set Feature succeeds or fails, CXL subsystem always
> needs to return a structure fwctl_rpc_cxl_out to caller, and returned
> size is updated in a rpc_out parameter. The rpc_out is only updated in
> success case at this moment, it should also be updated in failure cases.
>
> Signed-off-by: Li Ming <ming.li@...omail.com>
> ---
>  drivers/cxl/core/features.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index fcc624cefe89..63f24f032209 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -540,13 +540,13 @@ static void *cxlctl_set_feature(struct cxl_features_state *cxlfs,
>  	rc = cxl_set_feature(cxl_mbox, &feat_in->uuid,
>  			     feat_in->version, feat_in->feat_data,
>  			     data_size, flags, offset, &return_code);
> +	*out_len = sizeof(*rpc_out);
>  	if (rc) {
>  		rpc_out->retval = return_code;
>  		return no_free_ptr(rpc_out);
>  	}
>  
>  	rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
> -	*out_len = sizeof(*rpc_out);
>  
>  	return no_free_ptr(rpc_out);
>  }

Sorry, please ignore this patch, Wrong description in changelog, already send out v2 for review.


Ming