linux-kernel - Re: [PATCH] mmc: alcor: Use str_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFouaoE67WtdnQvohT9VjqCVC6CeFaCg0WZDWnVF5G+YNg@mail.gmail.com>
Date: Wed, 9 Apr 2025 15:13:49 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: shao.mingyin@....com.cn
Cc: yang.yang29@....com.cn, xu.xin16@....com.cn, ye.xingchen@....com.cn, 
	feng.wei8@....com.cn, u.kleine-koenig@...libre.com, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: alcor: Use str_read_write() helper

On Tue, 1 Apr 2025 at 13:58, <shao.mingyin@....com.cn> wrote:
>
> From: Feng Wei <feng.wei8@....com.cn>
>
> Remove hard-coded strings by using the str_read_write() helper.
>
> Signed-off-by: Feng Wei <feng.wei8@....com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/alcor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c
> index b6b6dd677ae5..24abd3a93da9 100644
> --- a/drivers/mmc/host/alcor.c
> +++ b/drivers/mmc/host/alcor.c
> @@ -20,6 +20,7 @@
>  #include <linux/irq.h>
>  #include <linux/interrupt.h>
>  #include <linux/platform_device.h>
> +#include <linux/string_choices.h>
>
>  #include <linux/mmc/host.h>
>  #include <linux/mmc/mmc.h>
> @@ -208,7 +209,7 @@ static void alcor_trf_block_pio(struct alcor_sdmmc_host *host, bool read)
>         len = min(host->sg_miter.length, blksize);
>
>         dev_dbg(host->dev, "PIO, %s block size: 0x%zx\n",
> -               read ? "read" : "write", blksize);
> +               str_read_write(read), blksize);
>
>         host->sg_miter.consumed = len;
>         host->blocks--;
> --
> 2.25.1