linux-kernel - Re: [PATCH] interconnect: samsung: Add NULL check in exynos_generic_icc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9cc33c4b-05e6-4203-8762-205eb3d4e9df@kernel.org>
Date: Thu, 10 Apr 2025 14:16:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charles Han <hanchunchao@...pur.com>, s.nawrocki@...sung.com,
 a.swigon@...sung.com, djakov@...nel.org, alim.akhtar@...sung.com,
 cw00.choi@...sung.com
Cc: linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] interconnect: samsung: Add NULL check in
 exynos_generic_icc_probe

On 10/04/2025 13:04, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in exynos_generic_icc_probe() is not checked.
> Add NULL check in exynos_generic_icc_probe(), to handle kernel NULL
> pointer dereference error.
> 
> Fixes: 2f95b9d5cf0b ("interconnect: Add generic interconnect driver for Exynos SoCs")
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>  drivers/interconnect/samsung/exynos.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/interconnect/samsung/exynos.c b/drivers/interconnect/samsung/exynos.c
> index 9e041365d909..f3568f0d92d1 100644
> --- a/drivers/interconnect/samsung/exynos.c
> +++ b/drivers/interconnect/samsung/exynos.c
> @@ -134,6 +134,11 @@ static int exynos_generic_icc_probe(struct platform_device *pdev)
>  	priv->node = icc_node;
>  	icc_node->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOFn",
>  					bus_dev->of_node);
> +	if (!icc_node->name) {
> +		devm_kfree(&pdev->dev, priv);

Instead of doing some scripting changes you need to look at the code.
Look at other error paths, how they are doing it.

Otherwise please explain why you need to release a managed resource?

Best regards,
Krzysztof