linux-kernel - [PATCH 6/6] staging: rtl8723bs: Initialize variables at declaration in rtl8723bs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6acc4efa84d38f5da7cb718d383664832bfb0370.1744285781.git.karanja99erick@gmail.com>
Date: Thu, 10 Apr 2025 16:06:11 +0300
From: Erick Karanja <karanja99erick@...il.com>
To: gregkh@...uxfoundation.org,
	outreachy@...ts.linux.dev
Cc: karanja99erick@...il.com,
	philipp.g.hortmann@...il.com,
	linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: [PATCH 6/6] staging: rtl8723bs: Initialize variables at declaration in rtl8723bs_recv.c

Make the code more concise and readable by integrating the initialization
directly into the variable declaration in cases where the initialization
is simple and doesn't depend on other variables or complex expressions.

Signed-off-by: Erick Karanja <karanja99erick@...il.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
index 28c914ec2604..8d0d8e8e837e 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
@@ -367,14 +367,11 @@ static void rtl8723bs_recv_tasklet(struct tasklet_struct *t)
  */
 s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
 {
-	s32 res;
+	s32 res = _SUCCESS;
 	u32 i, n;
-	struct recv_priv *precvpriv;
+	struct recv_priv *precvpriv = &padapter->recvpriv;
 	struct recv_buf *precvbuf;
 
-	res = _SUCCESS;
-	precvpriv = &padapter->recvpriv;
-
 	/* 3 1. init recv buffer */
 	INIT_LIST_HEAD(&precvpriv->free_recv_buf_queue.queue);
 	spin_lock_init(&precvpriv->free_recv_buf_queue.lock);
@@ -453,11 +450,9 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
 void rtl8723bs_free_recv_priv(struct adapter *padapter)
 {
 	u32 i;
-	struct recv_priv *precvpriv;
+	struct recv_priv *precvpriv = &padapter->recvpriv;
 	struct recv_buf *precvbuf;
 
-	precvpriv = &padapter->recvpriv;
-
 	/* 3 1. kill tasklet */
 	tasklet_kill(&precvpriv->recv_tasklet);
 
-- 
2.43.0