linux-kernel - Re: [PATCH net-next v2 03/13] rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409190601.2e47f43b@kernel.org>
Date: Wed, 9 Apr 2025 19:06:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: netdev@...r.kernel.org, Marc Dionne <marc.dionne@...istor.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Christian
 Brauner <brauner@...nel.org>, Chuck Lever <chuck.lever@...cle.com>,
 linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 03/13] rxrpc: Allow CHALLENGEs to the passed
 to the app for a RESPONSE

On Mon,  7 Apr 2025 17:11:16 +0100 David Howells wrote:
> +static int rxrpc_respond_to_oob(struct rxrpc_sock *rx,
> +				struct rxrpc_oob_params *p,
> +				struct msghdr *msg)
> +	__releases(&rx->sk.sk_lock.slock)

sparse still complains (or maybe in fact it complains because it sees
the annotation?):

net/rxrpc/oob.c:173:12: warning: context imbalance in 'rxrpc_respond_to_oob' - wrong count at exit
net/rxrpc/oob.c:223:5: warning: context imbalance in 'rxrpc_sendmsg_oob' - wrong count at exit

Not a deal breaker, just wanted to mention it.