Message-ID: <755ad3ff-17d5-4610-94ce-2f2d775b518d@sk.com>
Date: Thu, 10 Apr 2025 22:25:22 +0900
From: Honggyu Kim <honggyu.kim@...com>
To: David Hildenbrand <david@...hat.com>, Rakie Kim <rakie.kim@...com>,
 akpm@...ux-foundation.org
Cc: kernel_team@...ynix.com, gourry@...rry.net, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
 joshua.hahnjy@...il.com, dan.j.williams@...el.com,
 ying.huang@...ux.alibaba.com, Jonathan.Cameron@...wei.com,
 osalvador@...e.de, yunjeong.mun@...com
Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted
 interleave

Hi David,

On 4/9/2025 8:52 PM, David Hildenbrand wrote:
> On 09.04.25 13:39, Honggyu Kim wrote:
>> Hi David,
>>
>> On 4/9/2025 6:05 PM, David Hildenbrand wrote:
>>> On 08.04.25 09:32, Rakie Kim wrote:
[...snip...]
>>>> Signed-off-by: Rakie Kim <rakie.kim@...com>
>>>> Signed-off-by: Honggyu Kim <honggyu.kim@...com>
>>>> Signed-off-by: Yunjeong Mun <yunjeong.mun@...com>
>>>
>>> Why are the other SOF in there? Are there Co-developed-by missing?
>>
>> I initially found the problem and fixed it with my internal implementation but
>> Rakie also had his idea so he started working on it.  His initial implementation
>> has almost been similar to mine.
>>
>> I thought Signed-off-by is a way to express the patch series contains our
>> contribution, but if you think it's unusual, then I can add this.
> 
> Please see Documentation/process/submitting-patches.rst,

Thanks for the info.

> and note that these are not "patch delivery" SOB.
> 
> "
> The Signed-off-by: tag indicates that the signer was involved in the
> development of the patch, or that he/she was in the patch's delivery path.

Yunjeong and I have been involved in finding the problem and also concluded this
issue is related to hotplug together with our initial implementations before
this patch.  So I guess it is the former case.

> "
> 
> and
> 
> "
> Co-developed-by: states that the patch was co-created by multiple developers;
> it is used to give attribution to co-authors (in addition to the author
> attributed by the From: tag) when several people work on a single patch.  Since
> Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
> followed by a Signed-off-by: of the associated co-author.  Standard sign-off

So the Co-developed-by comes before Signed-off-by.

> procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
> chronological history of the patch insofar as possible, regardless of whether
> the author is attributed via From: or Co-developed-by:.  Notably, the last
> Signed-off-by: must always be that of the developer submitting the patch.
> "
> 
> The SOB order here is also not correct.

It looks the below order is correct.  I saw this order in the official document
example as well.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc1#n516

>>     Co-developed-by: Honggyu Kim <honggyu.kim@...com>
>>     Signed-off-by: Honggyu Kim <honggyu.kim@...com>
>>
>> For Yunjeong, the following can be added.
>>
>>     Tested-by: Yunjeong Mun <yunjeong.mun@...com>
> 
> That is probably the right thing to do if contribution was focused on testing.
> 
>>
>> However, this patch series is already in Andrew's mm-new so I don't want to
>> bother him again unless we need to update this patches for other reasons.
> 
> mm-new is exactly for these kind of things. We can ask Andrew to fix it up.

Rakie already asked him and he will update signinig tags at the next spin.
Thanks very much for your help!

Thanks,
Honggyu

Powered by blists - more mailing lists