linux-kernel - Re: [PATCH 14/19] dt-bindings: arm/cpus: Add schemas for "enable-method" dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nmqw3wbmltbji4cwtifjbxkfm4uprwqvp2vdovnzueay7r26ml@eimrqf54mb34>
Date: Thu, 10 Apr 2025 17:14:40 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Rob Herring <robh@...nel.org>
Cc: Stephan Gerhold <stephan.gerhold@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>, linux-kernel@...r.kernel.org,
        Conor Dooley <conor@...nel.org>, linux-rockchip@...ts.infradead.org,
        Daniel Machon <daniel.machon@...rochip.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, UNGLinuxDriver@...rochip.com,
        Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>, linux-sunxi@...ts.linux.dev,
        Liviu Dudau <liviu.dudau@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Fabio Estevam <festevam@...il.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-renesas-soc@...r.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Viresh Kumar <vireshk@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        zhouyanjie@...yeetech.com, Claudiu Beznea <claudiu.beznea@...on.dev>,
        Heiko Stuebner <heiko@...ech.de>,
        Jernej Skrabec <jernej.skrabec@...il.com>, linux-pm@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, Chen-Yu Tsai <wens@...e.org>,
        linux-mips@...r.kernel.org, imx@...ts.linux.dev,
        Samuel Holland <samuel@...lland.org>,
        Sudeep Holla <sudeep.holla@....com>, Nishanth Menon <nm@...com>,
        devicetree@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-arm-msm@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        linux-amlogic@...ts.infradead.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 14/19] dt-bindings: arm/cpus: Add schemas for
 "enable-method" dependencies

On Thu, Apr 10, 2025 at 09:11:22AM -0500, Rob Herring wrote:
> On Fri, Apr 4, 2025 at 9:56 AM Rob Herring (Arm) <robh@...nel.org> wrote:
> >
> >
> > On Thu, 03 Apr 2025 21:59:35 -0500, Rob Herring (Arm) wrote:
> > > Replace the prose for properties dependent on specific "enable-method"
> > > values with schemas defining the same requirements.
> > >
> > > Both "qcom,acc" and "qcom,saw" properties appear to be required for any
> > > of the Qualcomm enable-method values, so the schema is a bit simpler
> > > than what the text said. The references to arm/msm/qcom,saw2.txt and
> > > arm/msm/qcom,kpss-acc.txt are out of date, so just drop them.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > > ---
> > >  Documentation/devicetree/bindings/arm/cpus.yaml | 82 +++++++++++++++----------
> > >  1 file changed, 49 insertions(+), 33 deletions(-)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,saw2.example.dtb: cpu@0: 'qcom,acc' is a required property
> >         from schema $id: http://devicetree.org/schemas/arm/cpus.yaml#
> 
> Any Qcom folks want to tell me whether both qcom,acc and qcom,saw are
> required or not? All the actual users have both.

Yes, as far as I remember.

-- 
With best wishes
Dmitry