linux-kernel - Re: [PATCH] drivers/base/memory: Avoid overhead from for_each_present_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32c7a1e6-37fa-4d40-b09f-93712a69f062@redhat.com>
Date: Thu, 10 Apr 2025 16:24:26 +0200
From: David Hildenbrand <david@...hat.com>
To: Oscar Salvador <osalvador@...e.de>
Cc: Gavin Shan <gshan@...hat.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, adityag@...ux.ibm.com, donettom@...ux.ibm.com,
 gregkh@...uxfoundation.org, rafael@...nel.org, dakr@...nel.org,
 akpm@...ux-foundation.org, shan.gavin@...il.com
Subject: Re: [PATCH] drivers/base/memory: Avoid overhead from
 for_each_present_section_nr()

On 10.04.25 15:55, Oscar Salvador wrote:
> On Thu, Apr 10, 2025 at 03:18:00PM +0200, David Hildenbrand wrote:
>> Staring at the end result and the particularly long comment, are we now
>> really any better than before 61659efdb35c?
> 
> I think we are.

I think you are right. The whole comment can IMHO be heavily simplified. 
Makes it sound more complicated that it actually is ...

/*
  * Create memory blocks to span all present memory sections. Take care
  * of memory blocks that span multiple sections.
  */

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb