linux-kernel - Re: [PATCH v3] riscv: KGDB: Do not inline arch_kgdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3A22DFCBC7B91F71+320f58c6-0fc6-4dc4-9fb0-ab0d55be697a@uniontech.com>
Date: Thu, 10 Apr 2025 22:28:39 +0800
From: WangYuli <wangyuli@...ontech.com>
To: Alexandre Ghiti <alex@...ti.fr>, paul.walmsley@...ive.com,
 palmer@...belt.com, aou@...s.berkeley.edu
Cc: chenhuacai@...nel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, vincent.chen@...ive.com,
 palmerdabbelt@...gle.com, samuel.holland@...ive.com, zhanjun@...ontech.com,
 niecheng1@...ontech.com, guanwentao@...ontech.com,
 Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v3] riscv: KGDB: Do not inline arch_kgdb_breakpoint()

Hi Alex

On 2025/4/10 21:42, Alexandre Ghiti wrote:
> Hi WangYuli,
>
>
> You forgot to replace kgdb_breakinst into kgdb_compiled_break.

OK, I'll fix it.

Thanks,

>
> You are fixing 2 things here, you need to split this patch into 2. 
OK,
> And as noted by Palmer, we actually don't need norvc here, so you can 
> remove it instead.

I have some questions regarding this.

If .option norvc is unnecessary, what is the significance of .option 
push/.option pop?

Should they also be removed as well?

However, will this still function properly when the RISC-V C extension 
is active?


Thanks,

-- 
WangYuli

Download attachment "OpenPGP_0xC5DA1F3046F40BEE.asc" of type "application/pgp-keys" (633 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)