linux-kernel - Re: [PATCH v2 1/2] HID: HID_APPLETB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB95973CC9AD4C05E8241116F3B8B72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 10 Apr 2025 20:23:06 +0530
From: Aditya Garg <gargaditya08@...e.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Kerem Karabay <kekrby@...il.com>,
 "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] HID: HID_APPLETB_KBD should depend on X86



On 10-04-2025 08:10 pm, Geert Uytterhoeven wrote:
> Hi Aditya,
> 
> On Thu, 10 Apr 2025 at 10:52, Aditya Garg <gargaditya08@...e.com> wrote:
>>> On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@...der.be> wrote:
>>> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
>>> dependency on X86, to prevent asking the user about this driver when
>>> configuring a kernel for a different architecture.
>>
>> There are a lot of spaces before Hence.
> 
> That is intentional: double space between sentences.

Interesting choice

> 
>> Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs.
> 
> Why is there a separate driver for Arm Macs?

Because it is a completely different hardware on M1 Macs. On x86 Macs, it is a USB device + has both keyboard and drm mode. The keyboard mode makes it display a predefined set of keys and was made for Windows Bootcamp. The DRM mode, makes it a separate display, made for macOS.

On the M1s, it is not a USB device, nor has a keyboard mode. I forgot what exactly it used at the lower level, but it was quite different from the x86 Macs

> Which driver is that?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/adp/adp_drv.c?h=v6.15-rc1
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/input/touchscreen/apple_z2.c?h=v6.15-rc1
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>