linux-kernel - Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffd1f317-f4d9-4a39-ae6c-04afd7fddc0f@linuxfoundation.org>
Date: Thu, 10 Apr 2025 09:33:16 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>, Willy Tarreau <w@....eu>,
 Thomas Weißschuh <linux@...ssschuh.net>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant
 argument warning

On 4/7/25 00:52, Thomas Weißschuh wrote:
> For tests without fixtures the variant argument is unused.
> This is intentional, prevent to compiler from complaining.
> 

Include the warning in the change log for reference.

> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
>   tools/testing/selftests/kselftest_harness.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index bac4327775ea65dbe977e9b22ee548bedcbd33ff..2b350ed60b2bf1cbede8e3a9b4ac5fe716900144 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -174,7 +174,7 @@
>   	static void test_name(struct __test_metadata *_metadata); \
>   	static inline void wrapper_##test_name( \
>   		struct __test_metadata *_metadata, \
> -		struct __fixture_variant_metadata *variant) \
> +		struct __fixture_variant_metadata __attribute__((unused)) *variant) \
>   	{ \
>   		_metadata->setup_completed = true; \
>   		if (setjmp(_metadata->env) == 0) \
> 

thanks,
-- Shuah