linux-kernel - Re: [PATCH 8/9] arm64: dts: imx8mm-beacon: Enable RTC interrupt and wakeup-source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z/fuTHDdrbp2yApZ@lizhi-Precision-Tower-5810>
Date: Thu, 10 Apr 2025 12:14:04 -0400
From: Frank Li <Frank.li@....com>
To: Adam Ford <aford173@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org, aford@...conembedded.com,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/9] arm64: dts: imx8mm-beacon: Enable RTC interrupt and
 wakeup-source

On Wed, Apr 09, 2025 at 07:59:02PM -0500, Adam Ford wrote:
> The external RTC has the ability to be used as an alarm when
> interrupts are enabled and configured as a wakeup-source.

configure it as a wakeup-source.

wrap at 75 char to max ulitize screen width.

>
> Signed-off-by: Adam Ford <aford173@...il.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> index ed7a1be4a1a6..8d4d1c86ad71 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> @@ -235,8 +235,13 @@ eeprom@50 {
>
>  	rtc: rtc@51 {
>  		compatible = "nxp,pcf85263";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_rtc>;
>  		reg = <0x51>;

reg should be after compatible

so pinctrl-names should be after reg;

Frank
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <13 IRQ_TYPE_LEVEL_LOW>;
>  		quartz-load-femtofarads = <12500>;
> +		wakeup-source;
>  	};
>  };
>
> @@ -354,6 +359,12 @@ MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3	0x141
>  		>;
>  	};
>
> +	pinctrl_rtc: rtcgrp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_GPIO1_IO13_GPIO1_IO13	0x146
> +		>;
> +	};
> +
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <
>  			MX8MM_IOMUXC_UART1_RXD_UART1_DCE_RX	0x140
> --
> 2.48.1
>