linux-kernel - Re: [PATCH next] wifi: ath12k: Fix a couple NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88ee501b-7c1b-c8d1-9c7d-ad11c87e7530@quicinc.com>
Date: Thu, 10 Apr 2025 22:36:21 +0530
From: Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
        Sowmiya Sree Elavalagan
	<quic_ssreeela@...cinc.com>
CC: Jeff Johnson <jjohnson@...nel.org>,
        Raj Kumar Bhagat
	<quic_rajkbhag@...cinc.com>,
        Vasanthakumar Thiagarajan
	<vasanthakumar.thiagarajan@....qualcomm.com>,
        Balamurugan S
	<quic_bselvara@...cinc.com>,
        P Praneesh <quic_ppranees@...cinc.com>,
        <linux-wireless@...r.kernel.org>, <ath12k@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] wifi: ath12k: Fix a couple NULL vs IS_ERR() bugs



On 4/10/2025 9:56 PM, Dan Carpenter wrote:
> The devm_memremap() function returns error pointers on error and the
> ioremap() function returns NULL on error.  The error checking here got
> those flipped around.
> 
> Fixes: c01d5cc9b9fe ("wifi: ath12k: Power up userPD")
> Fixes: 6cee30f0da75 ("wifi: ath12k: add AHB driver support for IPQ5332")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/net/wireless/ath/ath12k/ahb.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
> index a9d9943a73f4..636dfe237a79 100644
> --- a/drivers/net/wireless/ath/ath12k/ahb.c
> +++ b/drivers/net/wireless/ath/ath12k/ahb.c
> @@ -360,10 +360,10 @@ static int ath12k_ahb_power_up(struct ath12k_base *ab)
>   	mem_phys = rmem->base;
>   	mem_size = rmem->size;
>   	mem_region = devm_memremap(dev, mem_phys, mem_size, MEMREMAP_WC);
> -	if (!mem_region) {
> +	if (IS_ERR(mem_region)) {
>   		ath12k_err(ab, "unable to map memory region: %pa+%pa\n",
>   			   &rmem->base, &rmem->size);
> -		return -ENOMEM;
> +		return PTR_ERR(mem_region);
>   	}
>   
>   	snprintf(fw_name, sizeof(fw_name), "%s/%s/%s%d%s", ATH12K_FW_DIR,
> @@ -929,7 +929,7 @@ static int ath12k_ahb_resource_init(struct ath12k_base *ab)
>   		 * for accessing them.
>   		 */
>   		ab->mem_ce = ioremap(ce_remap->base, ce_remap->size);
> -		if (IS_ERR(ab->mem_ce)) {
> +		if (!ab->mem_ce) {
>   			dev_err(&pdev->dev, "ce ioremap error\n");
>   			ret = -ENOMEM;
>   			goto err_mem_unmap;

Thanks for fixing it.

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@....qualcomm.com>