| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+T6QPm2gVSa_+-vj5EA=RAs_sZFjq0LJKYVKPf_LN9Xc9uQQQ@mail.gmail.com>
Date: Thu, 10 Apr 2025 13:26:53 -0400
From: Jason Kridner <jkridner@...gleboard.org>
To: Nishanth Menon <nm@...com>
Cc: Robert Nelson <robertcnelson@...il.com>, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Vignesh Raghavendra <vigneshr@...com>, Andrew Davis <afd@...com>, Roger Quadros <rogerq@...nel.org>,
Siddharth Vadapalli <s-vadapalli@...com>, Judith Mendez <jm@...com>, Andrei Aldea <a-aldea@...com>,
Dhruva Gole <d-gole@...com>, Deepak Khatri <lorforlinux@...gleboard.org>,
Ayush Singh <ayush@...gleboard.org>, michael.opdenacker@...tcommit.com
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: Add k3-am62-pocketbeagle2
On Thu, Apr 10, 2025 at 12:15 PM Nishanth Menon <nm@...com> wrote:
>
> On 18:18-20250408, Robert Nelson wrote:
> > BeagleBoard.org PocketBeagle 2 is an upgraded version of the popular
> > PocketBeagle. It is based on Texas Instruments AM6232 or AM6254 SoC.
> > Its dual or quad A53 cores can provide higher performance than classic
> > PocketBeagle. The new design comes with pre-soldered headers, a 3-pin
> > JST-SH 1.00mm UART debug port, a USB-C port, Texas Instruments
> > MSPM0L1105 Cortex-M0+ MCU for ADC, 512MB RAM, and a LiPo Battery charger.
> >
> > https://www.beagleboard.org/boards/pocketbeagle-2
> > https://openbeagle.org/pocketbeagle/pocketbeagle-2
> >
> > Signed-off-by: Robert Nelson <robertcnelson@...il.com>
> > CC: Rob Herring <robh@...nel.org>
> > CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> > CC: Conor Dooley <conor+dt@...nel.org>
> > CC: Vignesh Raghavendra <vigneshr@...com>
> > CC: Nishanth Menon <nm@...com>
> > CC: Andrew Davis <afd@...com>
> > CC: Roger Quadros <rogerq@...nel.org>
> > CC: Siddharth Vadapalli <s-vadapalli@...com>
> > CC: Judith Mendez <jm@...com>
> > CC: Andrei Aldea <a-aldea@...com>
> > CC: Dhruva Gole <d-gole@...com>
> > CC: Jason Kridner <jkridner@...gleboard.org>
> > CC: Deepak Khatri <lorforlinux@...gleboard.org>
> > CC: Ayush Singh <ayush@...gleboard.org>
> > ---
> > Changes since v1:
> > - fix '_' in main-i2c2-default-pins
> > - aliases i2c match original pocketbeagle
> > - add mcu_m4fss with reseved memory and mailbox
> > - drop unused main_gpio0_pins_default pinmux
> > - drop unused main_gpio1_pins_default pinmux
> > - drop unused main_spi2_pins_gpio pinmux
> > - Reserve 128MiB of global CMA
> > ---
> > arch/arm64/boot/dts/ti/Makefile | 1 +
> > .../boot/dts/ti/k3-am62-pocketbeagle2.dts | 528 ++++++++++++++++++
> > 2 files changed, 529 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts
> >
> > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> > index 03d4cecfc001..4f8fcb69a2c1 100644
> > --- a/arch/arm64/boot/dts/ti/Makefile
> > +++ b/arch/arm64/boot/dts/ti/Makefile
> > @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-yavia.dtb
> > dtb-$(CONFIG_ARCH_K3) += k3-am62x-phyboard-lyra-gpio-fan.dtbo
> > dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk.dtb
> > dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk-nand.dtbo
> > +dtb-$(CONFIG_ARCH_K3) += k3-am62-pocketbeagle2.dtb
> >
> > # Boards with AM62Ax SoC
> > dtb-$(CONFIG_ARCH_K3) += k3-am62a7-sk.dtb
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts b/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts
> > new file mode 100644
> > index 000000000000..65000ed8196f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts
> > @@ -0,0 +1,528 @@
> > +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> > +/*
> > + * https://www.beagleboard.org/boards/pocketbeagle-2
> > + *
> > + * Copyright (C) 2025 Texas Instruments Incorporated - https://www.ti.com/
> > + * Copyright (C) 2025 Robert Nelson, BeagleBoard.org Foundation
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include "k3-am625.dtsi"
> > +
> > +/ {
> > + compatible = "beagle,am62-pocketbeagle2", "ti,am625";
> > + model = "BeagleBoard.org PocketBeagle2";
> > +
> > + aliases {
> > + serial0 = &wkup_uart0;
> > + serial1 = &main_uart1;
> > + serial2 = &main_uart6;
> > + serial3 = &main_uart3;
> > + serial4 = &main_uart4;
> > + serial5 = &main_uart5;
> > + serial6 = &main_uart2;
> > + serial7 = &main_uart0;
>
>
> We just seem to have 3 uarts pinned out. so why alias the rest? those
> seem unused?
>
> > + mmc0 = &sdhci0;
> Same - unused?
> > + mmc1 = &sdhci1;
> > + usb0 = &usb0;
> > + usb1 = &usb1;
> > + i2c1 = &main_i2c1;
>
> same - unused?
>
> > + i2c2 = &main_i2c2;
> > + i2c3 = &wkup_i2c0;
> > + };
> > +
> > + chosen {
> > + stdout-path = &main_uart6;
> > + };
> > +
> > + memory@...00000 {
> > + /* 512MB RAM */
> > + reg = <0x00000000 0x80000000 0x00000000 0x20000000>;
> > + device_type = "memory";
> > + bootph-pre-ram;
> > + };
> > +
> > + reserved_memory: reserved-memory {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + /* global cma region */
> > + linux,cma {
> > + compatible = "shared-dma-pool";
> > + reusable;
> > + size = <0x00 0x8000000>;
> > + linux,cma-default;
> > + };
> > +
> > + mcu_m4fss_dma_memory_region: m4f-dma-memory@...00000 {
> > + compatible = "shared-dma-pool";
> > + reg = <0x00 0x9cb00000 0x00 0x100000>;
> > + no-map;
> > + };
> > +
> > + mcu_m4fss_memory_region: m4f-memory@...00000 {
> > + compatible = "shared-dma-pool";
> > + reg = <0x00 0x9cc00000 0x00 0xe00000>;
> > + no-map;
> > + };
> > +
> > + secure_tfa_ddr: tfa@...80000 {
> > + reg = <0x00 0x9e780000 0x00 0x80000>;
> > + alignment = <0x1000>;
> > + no-map;
> > + };
> > +
> > + secure_ddr: optee@...00000 {
> > + reg = <0x00 0x9e800000 0x00 0x01800000>;
> > + alignment = <0x1000>;
> > + no-map;
> > + };
> > +
> > + wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@...00000 {
> > + compatible = "shared-dma-pool";
> > + reg = <0x00 0x9db00000 0x00 0xc00000>;
> > + no-map;
> > + };
> > + };
> > +
> > + vsys_5v0: regulator-1 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vsys_5v0";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + bootph-all;
> > + };
> > +
> > + vdd_3v3: regulator-2 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vdd_3v3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + vin-supply = <&vsys_5v0>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + bootph-all;
> > + };
> > +
> > + vdd_mmc1: regulator-3 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vdd_mmc1";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&vdd_3v3_sd_pins_default>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + enable-active-high;
> > + regulator-always-on;
> > + vin-supply = <&vdd_3v3>;
> > + gpio = <&main_gpio0 0 GPIO_ACTIVE_HIGH>;
> > + bootph-all;
> > + };
> > +
> > + vdd_sd_dv: regulator-4 {
> > + compatible = "regulator-gpio";
> > + regulator-name = "sd_hs200_switch";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&vdd_sd_dv_pins_default>;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + vin-supply = <&vdd_3v3>;
> > + gpios = <&main_gpio1 49 GPIO_ACTIVE_HIGH>;
> > + states = <1800000 0x0>,
> > + <3300000 0x1>;
> > + bootph-all;
> > + };
> > +
> > + adc_vref: regulator-5 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "default";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + };
> > +
> > + leds {
> > + bootph-all;
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&led_pins_default>;
> bootph-all here?
> Please check Documentation/devicetree/bindings/dts-coding-style.rst
>
> 1. "compatible"
> 2. "reg"
> 3. "ranges"
> 4. Standard/common properties (defined by common bindings, e.g. without
> vendor-prefixes)
>
> ^^ bootph property last one here.
>
> 5. Vendor-specific properties
> 6. "status" (if applicable)
> 7. Child nodes, where each node is preceded with a blank line
>
> Could you make sure that all the nodes follow the convention?
>
> > +
> > + led-1 {
> > + bootph-all;
> > + gpios = <&main_gpio0 6 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + linux,default-trigger = "heartbeat";
> > + function = LED_FUNCTION_HEARTBEAT;
> > + default-state = "on";
> Same
> > + };
> > +
> > + led-2 {
> > + bootph-all;
> > + gpios = <&main_gpio0 5 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_DISK_ACTIVITY;
> > + linux,default-trigger = "mmc1";
> > + };
> > +
> > + led-3 {
> > + bootph-all;
> > + gpios = <&main_gpio0 4 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + };
> > +
> > + led-4 {
> > + bootph-all;
> > + gpios = <&main_gpio0 3 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_INDICATOR;
> > + default-state = "off";
> > + };
> > + };
> > +};
> > +
> > +&main_pmx0 {
> > + led_pins_default: led-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x000c, PIN_OUTPUT, 7) /* (E25) OSPI0_D0.GPIO0_3 */
> > + AM62X_IOPAD(0x0010, PIN_OUTPUT, 7) /* (G24) OSPI0_D1.GPIO0_4 */
> > + AM62X_IOPAD(0x0014, PIN_OUTPUT, 7) /* (F25) OSPI0_D2.GPIO0_5 */
> > + AM62X_IOPAD(0x0018, PIN_OUTPUT, 7) /* (F24) OSPI0_D3.GPIO0_6 */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + main_i2c0_pins_default: main-i2c0-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (B16) I2C0_SCL */
> > + AM62X_IOPAD(0x01e4, PIN_INPUT_PULLUP, 0) /* (A16) I2C0_SDA */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + main_i2c2_pins_default: main-i2c2-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x00b0, PIN_INPUT_PULLUP, 1) /* (K22) GPMC0_CSn2.I2C2_SCL */
> > + AM62X_IOPAD(0x00b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + main_uart0_pins_default: main-uart0-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x1c8, PIN_INPUT, 0) /* (D14/A13) UART0_RXD */
> > + AM62X_IOPAD(0x1cc, PIN_OUTPUT, 0) /* (E14/E11) UART0_TXD */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + main_uart1_pins_default: main-uart1-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x194, PIN_INPUT, 2) /* (B19/B18) MCASP0_AXR3.UART1_CTSn */
> > + AM62X_IOPAD(0x198, PIN_OUTPUT, 2) /* (A19/B17) MCASP0_AXR2.UART1_RTSn */
> > + AM62X_IOPAD(0x1ac, PIN_INPUT, 2) /* (E19/D15) MCASP0_AFSR.UART1_RXD */
> > + AM62X_IOPAD(0x1b0, PIN_OUTPUT, 2) /* (A20/D16) MCASP0_ACLKR.UART1_TXD */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + main_uart6_pins_default: main-uart6-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x001c, PIN_INPUT, 3) /* (J23) OSPI0_D4.UART6_RXD */
> > + AM62X_IOPAD(0x0020, PIN_OUTPUT, 3) /* (J25) OSPI0_D5.UART6_TXD */
> > + >;
> > + };
> > +
> > + main_mmc1_pins_default: main-mmc1-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x23c, PIN_INPUT, 0) /* (A21/C18) MMC1_CMD */
> > + AM62X_IOPAD(0x234, PIN_INPUT, 0) /* (B22/A20) MMC1_CLK */
> > + AM62X_IOPAD(0x230, PIN_INPUT, 0) /* (A22/A19) MMC1_DAT0 */
> > + AM62X_IOPAD(0x22c, PIN_INPUT, 0) /* (B21/B19) MMC1_DAT1 */
> > + AM62X_IOPAD(0x228, PIN_INPUT, 0) /* (C21/B20) MMC1_DAT2 */
> > + AM62X_IOPAD(0x224, PIN_INPUT, 0) /* (D22/C19) MMC1_DAT3 */
> > + AM62X_IOPAD(0x240, PIN_INPUT, 7) /* (D17/C15) MMC1_SDCD.GPIO1_48 */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x0244, PIN_OUTPUT, 7) /* (P25) GPMC0_CLK.GPIO1_49 */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + pmic_irq_pins_default: pmic-irq-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x01f4, PIN_INPUT_PULLUP, 0) /* (D16) EXTINTn */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + vdd_3v3_sd_pins_default: vdd-3v3-sd-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x0000, PIN_OUTPUT, 7) /* (H24) OSPI0_CLK.GPIO0_0 */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + usb1_pins_default: usb1-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x0258, PIN_INPUT, 0) /* (F18) USB1_DRVVBUS */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + epwm2_pins_default: epwm2-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_IOPAD(0x01e8, PIN_OUTPUT, 8) /* (B17) I2C1_SCL.EHRPWM2_A */
> > + >;
> > + };
> > +};
> > +
> > +&cpsw3g {
> > + status = "disabled";
> > +};
>
> This should have been disabled at am62-main.dtsi level (like it was done
> in j784s4) - lets fix that then apply the pb2 without these disabled
> nodes.
> > +
> > +&cpsw_port1 {
> > + status = "disabled";
> > +};
> > +
> > +&cpsw_port2 {
> > + status = "disabled";
> > +};
> > +
> > +&epwm2 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&epwm2_pins_default>;
> > +};
> > +
> > +&mailbox0_cluster0 {
> > + mbox_m4_0: mbox-m4-0 {
> > + ti,mbox-rx = <0 0 0>;
> > + ti,mbox-tx = <1 0 0>;
> > + };
> > +};
> > +
> > +&main_uart0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&main_uart0_pins_default>;
> > + bootph-all;
> > + status = "okay";
> > +};
> > +
> > +&main_uart1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&main_uart1_pins_default>;
> > + bootph-pre-ram;
> > + status = "reserved";
> > +};
> > +
> > +&main_uart6 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&main_uart6_pins_default>;
> > + bootph-all;
> > + status = "okay";
> > +};
> > +
> > +&main_i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&main_i2c0_pins_default>;
> > + clock-frequency = <400000>;
> > + bootph-all;
> > + status = "okay";
> > +
> > + ad7291: adc@20 {
> > + compatible = "adi,ad7291";
>
> I think the commit message says MSPM0L1105 ? is this in emulation mode?
> if so, we should document this.
>
> > + reg = <0x20>;
> > + vref-supply = <&adc_vref>;
> > + };
> > +
> > + eeprom: eeprom@50 {
> > + compatible = "atmel,24c32";
>
> is this the same? MSPM0L1105 doing eeprom? if so, please document.
> > + reg = <0x50>;
> > + };
> > +};
> > +
> > +&main_i2c2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&main_i2c2_pins_default>;
> > + clock-frequency = <400000>;
> > + bootph-all;
> > + status = "okay";
> > +};
> > +
> > +&mcu_m4fss {
> > + mboxes = <&mailbox0_cluster0 &mbox_m4_0>;
> > + memory-region = <&mcu_m4fss_dma_memory_region>,
> > + <&mcu_m4fss_memory_region>;
> > + status = "okay";
> > +};
> > +
> > +&mcu_pmx0 {
> > + wkup_uart0_pins_default: wkup-uart0-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_MCU_IOPAD(0x02c, PIN_INPUT, 0) /* (C6/A7) WKUP_UART0_CTSn */
> > + AM62X_MCU_IOPAD(0x030, PIN_OUTPUT, 0) /* (A4/B4) WKUP_UART0_RTSn */
> > + AM62X_MCU_IOPAD(0x024, PIN_INPUT, 0) /* (B4/B5) WKUP_UART0_RXD */
> > + AM62X_MCU_IOPAD(0x028, PIN_OUTPUT, 0) /* (C5/C6) WKUP_UART0_TXD */
> > + >;
> > + bootph-all;
> > + };
> > +
> > + wkup_i2c0_pins_default: wkup-i2c0-default-pins {
> > + pinctrl-single,pins = <
> > + AM62X_MCU_IOPAD(0x004c, PIN_INPUT_PULLUP, 0) /* (B9) WKUP_I2C0_SCL */
> > + AM62X_MCU_IOPAD(0x0050, PIN_INPUT_PULLUP, 0) /* (A9) WKUP_I2C0_SDA */
> > + >;
> > + bootph-all;
> > + };
> > +};
> > +
> > +&sdhci1 {
> > + /* SD/MMC */
> > + vmmc-supply = <&vdd_mmc1>;
> > + vqmmc-supply = <&vdd_sd_dv>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&main_mmc1_pins_default>;
> > + disable-wp;
> > + cd-gpios = <&main_gpio1 48 GPIO_ACTIVE_LOW>;
> > + cd-debounce-delay-ms = <100>;
> > + bootph-all;
> > + ti,fails-without-test-cd;
> > + status = "okay";
> > +};
> > +
> > +&usbss0 {
> > + bootph-all;
> > + ti,vbus-divider;
> > + status = "okay";
> > +};
> > +
> > +&usb0 {
> > + bootph-all;
> > + dr_mode = "peripheral";
>
> Can this operate in "otg" instead? maybe use a type-c dock?
>
> > +};
> > +
> > +&usbss1 {
> > + ti,vbus-divider;
> > + status = "okay";
> > +};
> > +
> > +&usb1 {
> > + dr_mode = "host";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb1_pins_default>;
> > +};
>
> is'nt this over https://www.beagleboard.org/boards/techlab or
> https://www.beagleboard.org/boards/pocketbeagle-gamepup-cape or
> https://github.com/mwelling/pocket-bob ?
>
> I think it is better as an overlay? Let us not enable something that
> will add power for no benefit :)
> Further USB1.ID has options for PRU as well. Let the daughter overlay
> deal with it.
>
> On the flip side, we could work the other way - since majority of
> daughter cards use USB host, it could be that the other overlays can
> just disable usbss1 and usb1
>
> Thoughts?
Since you asked, Being the somewhat unique state of PocketBeagle 2 and
other Beagle
single-board computers as rapid-prototyping development platforms, my
personal general
preference is to see all the stuff turned on by default and then to
provide some clear direction
on what is not necessary such that it lives as documentation forhow to
enable it and simplify
the development of overlays. Some of the rationale for this was
discussed a couple
of years back in a series of blog posts by Michael Opdenacker. [1][2][3]
My perspective is that the interfaces need to be enabled to define the
header connector to
the device tree and that the muxes should further be fully described
to the system, rather than
leaving those bits of metadata regarding the running system as an
exercise for the reader.
The aforementioned approach of removing all the "dead bits" is great
until someone is left with
the challenge of figuring out how to turn them on and/or select
between them. Providing an
overlay that disables all the unnecessary bits seems reasonable to me.
Otherwise, I think we can put the entirety of the header description
into an overlay for
cape-specific overlays to use, but I find the lack of an upstream
definition to make it difficult to
enable cape makers to define overlays that are likely to actually work.
Just my $0.0000002.
[1] https://www.beagleboard.org/blog/2022-02-15-using-device-tree-overlays-example-on-beaglebone-cape-add-on-boards
[2] https://www.beagleboard.org/blog/2022-03-31-device-tree-supporting-similar-boards-the-beaglebone-example
[3] https://www.beagleboard.org/blog/2022-06-06-using-the-u-boot-extension-board-manager-beaglebone-boards-example
>
> > +
> > +&wkup_uart0 {
> > + /* WKUP UART0 is used by Device Manager firmware */
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&wkup_uart0_pins_default>;
> > + bootph-all;
> > + status = "reserved";
> > +};
> > +
> > +&wkup_i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&wkup_i2c0_pins_default>;
> > + clock-frequency = <100000>;
> > + bootph-all;
> > + status = "okay";
> > +
> > + tps65219: pmic@30 {
> > + compatible = "ti,tps65219";
> > + reg = <0x30>;
> > + buck1-supply = <&vsys_5v0>;
> > + buck2-supply = <&vsys_5v0>;
> > + buck3-supply = <&vsys_5v0>;
> > + ldo1-supply = <&vdd_3v3>;
> > + ldo2-supply = <&buck2_reg>;
> > + ldo3-supply = <&vdd_3v3>;
> > + ldo4-supply = <&vdd_3v3>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pmic_irq_pins_default>;
> > + interrupt-parent = <&gic500>;
> > + interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > +
> > + bootph-all;
> > + system-power-controller;
> > + ti,power-button;
> > +
> > + regulators {
> > + buck1_reg: buck1 {
> > + regulator-name = "VDD_CORE";
> > + regulator-min-microvolt = <850000>;
> > + regulator-max-microvolt = <850000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + buck2_reg: buck2 {
> > + regulator-name = "VDD_1V8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + buck3_reg: buck3 {
> > + regulator-name = "VDD_1V2";
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo1_reg: ldo1 {
> > + /*
> > + * Regulator is left as is unused, vdd_sd
> > + * is controlled via GPIO with bypass config
> > + * as per the NVM configuration
> > + */
> > + regulator-name = "VDD_SD_3V3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-allow-bypass;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo2_reg: ldo2 {
> > + regulator-name = "VDDA_0V85";
> > + regulator-min-microvolt = <850000>;
> > + regulator-max-microvolt = <850000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo3_reg: ldo3 {
> > + regulator-name = "VDDA_1V8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo4_reg: ldo4 {
> > + regulator-name = "VDD_2V5";
> > + regulator-min-microvolt = <2500000>;
> > + regulator-max-microvolt = <2500000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > + };
> > + };
> > +};
> > --
> > 2.47.2
> >
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
--
Learn about me and setup a meeting at
https://beagleboard.org/about/jkridner - a 501c3 non-profit educating
around open hardware computing
Powered by blists - more mailing lists