linux-kernel - RE: [PATCH v4 16/16] perf record: Retirement latency cleanup in evsel_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR11MB5635677AA5BCAC3E65B1274BEEB72@CO6PR11MB5635.namprd11.prod.outlook.com>
Date: Thu, 10 Apr 2025 03:12:31 +0000
From: "Wang, Weilin" <weilin.wang@...el.com>
To: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa
	<jolsa@...nel.org>, "Hunter, Adrian" <adrian.hunter@...el.com>, Kan Liang
	<kan.liang@...ux.intel.com>, James Clark <james.clark@...aro.org>, Xu Yang
	<xu.yang_2@....com>, John Garry <john.g.garry@...cle.com>, Howard Chu
	<howardchu95@...il.com>, Levi Yun <yeoreum.yun@....com>, Dominique Martinet
	<asmadeus@...ewreck.org>, "linux-perf-users@...r.kernel.org"
	<linux-perf-users@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 16/16] perf record: Retirement latency cleanup in
 evsel__config



> -----Original Message-----
> From: Ian Rogers <irogers@...gle.com>
> Sent: Tuesday, April 8, 2025 11:11 PM
> To: Peter Zijlstra <peterz@...radead.org>; Ingo Molnar <mingo@...hat.com>;
> Arnaldo Carvalho de Melo <acme@...nel.org>; Namhyung Kim
> <namhyung@...nel.org>; Mark Rutland <mark.rutland@....com>;
> Alexander Shishkin <alexander.shishkin@...ux.intel.com>; Jiri Olsa
> <jolsa@...nel.org>; Ian Rogers <irogers@...gle.com>; Hunter, Adrian
> <adrian.hunter@...el.com>; Kan Liang <kan.liang@...ux.intel.com>; Wang,
> Weilin <weilin.wang@...el.com>; James Clark <james.clark@...aro.org>; Xu
> Yang <xu.yang_2@....com>; John Garry <john.g.garry@...cle.com>; Howard
> Chu <howardchu95@...il.com>; Levi Yun <yeoreum.yun@....com>;
> Dominique Martinet <asmadeus@...ewreck.org>; linux-perf-
> users@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH v4 16/16] perf record: Retirement latency cleanup in
> evsel__config
> 
> Perf record will fail with retirement latency events as the open
> doesn't do a perf_event_open system call. Use evsel__config to set up
> such events for recording by removing the flag and enabling sample
> weights - the sample weights containing the retirement latency.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
Tested-by: Weilin Wang <weilin.wang@...el.com>

> ---
>  tools/perf/util/evsel.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 661a07cbdb25..6a84893e3c58 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1440,9 +1440,10 @@ void evsel__config(struct evsel *evsel, struct
> record_opts *opts,
>  		attr->branch_sample_type = opts->branch_stack;
>  	}
> 
> -	if (opts->sample_weight)
> +	if (opts->sample_weight || evsel->retire_lat) {
>  		arch_evsel__set_sample_weight(evsel);
> -
> +		evsel->retire_lat = false;
> +	}
>  	attr->task     = track;
>  	attr->mmap     = track;
>  	attr->mmap2    = track && !perf_missing_features.mmap2;
> --
> 2.49.0.504.g3bcea36a83-goog