linux-kernel - Re: [PATCH] firmware: cs_dsp: test_bin_error: Fix uninitialized data used as fw version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174431259161.501489.5379480875112527733.b4-ty@kernel.org>
Date: Thu, 10 Apr 2025 20:16:31 +0100
From: Mark Brown <broonie@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
 patches@...nsource.cirrus.com, kunit-dev@...glegroups.com, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] firmware: cs_dsp: test_bin_error: Fix uninitialized
 data used as fw version

On Thu, 10 Apr 2025 14:21:29 +0100, Richard Fitzgerald wrote:
> Call cs_dsp_mock_xm_header_get_fw_version() to get the firmware version
> from the dummy XM header data in cs_dsp_bin_err_test_common_init().
> 
> Make the same change to cs_dsp_bin_test_common_init() and remove the
> cs_dsp_mock_xm_header_get_fw_version_from_regmap() function.
> 
> The code in cs_dsp_test_bin.c was correctly calling
> cs_dsp_mock_xm_header_get_fw_version_from_regmap() to fetch the fw version
> from a dummy header it wrote to XM registers. However in
> cs_dsp_test_bin_error.c the test doesn't stuff a dummy header into XM, it
> populates it the normal way using a wmfw file. It should have called
> cs_dsp_mock_xm_header_get_fw_version() to get the data from its blob
> buffer, but was calling cs_dsp_mock_xm_header_get_fw_version_from_regmap().
> As nothing had been written to the registers this returned the value of
> uninitialized data.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] firmware: cs_dsp: test_bin_error: Fix uninitialized data used as fw version
      commit: 285b2c74cf9982e873ef82a2cb1328d9e9406f65

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark