linux-kernel - Re: [PATCH net-next] wifi: ath9k: use devm for irq and ioremap resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N-PpA2JLZu2Yt6-UOwW+7TEZfjJoiULve-jqnyyd-Sipw@mail.gmail.com>
Date: Thu, 10 Apr 2025 13:31:10 -0700
From: Rosen Penev <rosenp@...il.com>
To: Toke Høiland-Jørgensen <toke@...e.dk>
Cc: linux-wireless@...r.kernel.org, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] wifi: ath9k: use devm for irq and ioremap resource

On Thu, Apr 10, 2025 at 4:06 AM Toke Høiland-Jørgensen <toke@...e.dk> wrote:
>
> Rosen Penev <rosenp@...il.com> writes:
>
> > Avoids having to manually free. Both of these get called and removed in
> > probe only and are safe to convert.
>
> Erm, huh? The request_irq() change in ath_ahb_probe() is literally the
> same change that you sent once and that we had to revert. Not taking any
> more of these, sorry.
You're right about this. The first change is correct as it happens
before it is assigned to sc. Will send a v2 without irq changes.
>
> Nacked-by: Toke Høiland-Jørgensen <toke@...e.dk>