linux-kernel - Re: [PATCH v6 6/6] riscv: defconfig: enable clock controller unit support for SpacemiT K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_dFIavJT9_KwT1O@ketchup>
Date: Thu, 10 Apr 2025 04:12:17 +0000
From: Haylen Chu <heylenay@....org>
To: Alex Elder <elder@...cstar.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Haylen Chu <heylenay@...look.com>, Yixun Lan <dlan@...too.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>
Cc: linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	spacemit@...ts.linux.dev, Inochi Amaoto <inochiama@...look.com>,
	Chen Wang <unicornxdotw@...mail.com>,
	Jisheng Zhang <jszhang@...nel.org>,
	Meng Zhang <zhangmeng.kevin@...ux.spacemit.com>
Subject: Re: [PATCH v6 6/6] riscv: defconfig: enable clock controller unit
 support for SpacemiT K1

On Tue, Apr 08, 2025 at 02:37:35PM -0500, Alex Elder wrote:
> On 4/1/25 12:24 PM, Haylen Chu wrote:
> > Clock controller unit, or CCU, generates various clocks frequency for
> > peripherals integrated in SpacemiT K1 SoC and is essential for normal
> > operation. Let's enable it in defconfig.
> > 
> > Signed-off-by: Haylen Chu <heylenay@....org>
> > ---
> >   arch/riscv/configs/defconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 0f7dcbe3c45b..011788d16d93 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -252,6 +252,8 @@ CONFIG_CLK_SOPHGO_CV1800=y
> >   CONFIG_CLK_SOPHGO_SG2042_PLL=y
> >   CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y
> >   CONFIG_CLK_SOPHGO_SG2042_RPGATE=y
> > +CONFIG_SPACEMIT_CCU=y
> > +CONFIG_SPACEMIT_K1_CCU=y
> 
> Maybe these could be specified with default values that
> are based on the value of CONFIG_ARCH_SPACEMIT instead of
> forcing them to be defined here?

As mentioned by Inochi earlier[1], putting defaults configuration in
defconfig instead through a "default" kconfig property is the preference
of clk subsystem, so I'd like to follow.

> 					-Alex
> 
> >   CONFIG_SUN8I_DE2_CCU=m
> >   CONFIG_SUN50I_IOMMU=y
> >   CONFIG_RPMSG_CHAR=y
> 

Regards,
Haylen Chu

[1] https://lore.kernel.org/all/xwo2jjqy634z4rimgyrbjmxlgzxzauxmqzl57qr5oasph74qwj@7we45fnhwfzh/