linux-kernel - Re: [RFC -v2] wifi: rtw88: sdio: Tx status for management frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCBHqwhtSAqE8xCoxsgRgHZ1n-zGC6wXo+emAaX6BBkR1A@mail.gmail.com>
Date: Thu, 10 Apr 2025 07:54:15 +0200
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Zhen XIN <zhen.xin@...ia-sbell.com>, 
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC -v2] wifi: rtw88: sdio: Tx status for management frames

Hi Ping-Ke,

On Thu, Apr 10, 2025 at 6:30 AM Ping-Ke Shih <pkshih@...ltek.com> wrote:
[...]
> > @@ -718,10 +718,7 @@ static u8 rtw_sdio_get_tx_qsel(struct rtw_dev *rtwdev, struct sk_buff *skb,
> >         case RTW_TX_QUEUE_H2C:
> >                 return TX_DESC_QSEL_H2C;
> >         case RTW_TX_QUEUE_MGMT:
> > -               if (rtw_chip_wcpu_11n(rtwdev))
> > -                       return TX_DESC_QSEL_HIGH;
> > -               else
> > -                       return TX_DESC_QSEL_MGMT;
> > +               return TX_DESC_QSEL_MGMT;
>
> Do you remember why you did the special deal with 11n chips?
> And this RFC looks good to me. (except to commit message, but this is RFC)
I don't remember - and Jernej said the same thing.
However, since we got the first 802.11n hardware for testing long
after this part was written my suggestion is: let's roll this into a
proper patch, Cc Fiona Klute <fiona.klute@....de> (author of RTL8723CS
support) on the resulting patch(es) and then apply the patches
(assuming nobody observes any problems).

To make this a non-RFC patch the following steps are needed (in my opinion):
- split the change into two patches (one which unconditionally calls
rtw_sdio_indicate_tx_status())
- another one for the TX_DESC_QSEL_MGMT mapping
- each of the patches should include their own description
- I checked the history and it seems that both problems were
introduced with the original commit, meaning both patches should get
the following line (above the Signed-off-by): Fixes: 65371a3f14e7
("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
- (plus anything Ping-Ke has to add :-) )


Best regards,
Martin