linux-kernel - Re: [PATCH] x86/Kconfig: Fix dependency for X86_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_dl0HhwMOBkVTFH@gmail.com>
Date: Thu, 10 Apr 2025 08:31:44 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH] x86/Kconfig: Fix dependency for X86_DEBUG_FPU


* Shuah Khan <skhan@...uxfoundation.org> wrote:

> Yes it is vanilla

Thx.

> > More importantly, X86_REQUIRED_FEATURE_FPU *does not exist* in the 
> > vanilla v6.14 kernel, it's a new v6.15 feature. So this part of 
> > your changelog totally doesn't apply to a v6.14 kernel:
> 
> I started with vanilla 6.14 kernel running oldconfig on it. In this 
> case if X86_DEBUG_FPU is enabled in the oldconfig, should the config 
> generated for 6.15 add X86_REQUIRED_FEATURE_FPU.
> 
> It appears there is a dependency between X86_DEBUG_FPU and the newly 
> added X86_REQUIRED_FEATURE_FPU

Could you send the v6.15-rc1 config that has this missing dependency?

Because if I put the config you sent through 'make oldconfig' and 
accept all default suggestions, the X86_REQUIRED_FEATURE_FPU dependency 
is present:

 starship:~/tip> grep _FPU .config
 CONFIG_X86_REQUIRED_FEATURE_FPU=y
 CONFIG_ARCH_HAS_KERNEL_FPU_SUPPORT=y
 CONFIG_X86_DEBUG_FPU=y
 # CONFIG_TEST_FPU is not set

... and the build succeeds:

    OBJCOPY arch/x86/boot/setup.bin
    BUILD   arch/x86/boot/bzImage
  Kernel: arch/x86/boot/bzImage is ready  (#4)

Ie. I cannot reproduce the build failure with the config you provided.

Thanks,

	Ingo