linux-kernel - Re: [PATCH] perf test: Remove the temporary trace record file when the test fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_du4e4X1B8Ib_xN@z2>
Date: Thu, 10 Apr 2025 00:10:25 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Howard Chu <howardchu95@...il.com>
Cc: acme@...nel.org, mingo@...hat.com, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com, peterz@...radead.org,
	kan.liang@...ux.intel.com, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf test: Remove the temporary trace record file when
 the test fails

On Fri, Apr 04, 2025 at 06:47:57PM -0700, Howard Chu wrote:
> Even if there's no nanosleep in the trace record file, it doesn't mean
> the file itself doesn't exist. Remove the temporary file since the test
> frequently fails on my machine and leaves behind many uncleaned
> temporary files.
> 
> Signed-off-by: Howard Chu <howardchu95@...il.com>

Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> ---
>  tools/perf/tests/shell/trace_record_replay.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/shell/trace_record_replay.sh b/tools/perf/tests/shell/trace_record_replay.sh
> index 6b4ed863c1ef..555537dc6cfa 100755
> --- a/tools/perf/tests/shell/trace_record_replay.sh
> +++ b/tools/perf/tests/shell/trace_record_replay.sh
> @@ -15,6 +15,7 @@ file=$(mktemp /tmp/temporary_file.XXXXX)
>  perf trace record -o ${file} sleep 1 || exit 1
>  if ! perf trace -i ${file} 2>&1 | grep nanosleep; then
>  	echo "Failed: cannot find *nanosleep syscall"
> +	rm -f ${file}
>  	exit 1
>  fi
>  
> -- 
> 2.45.2
>