linux-kernel - Re: [PATCH 00/20] x86 MSR in-kernel API type cleanup and rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250410073107.GS9833@noisy.programming.kicks-ass.net>
Date: Thu, 10 Apr 2025 09:31:07 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Juergen Gross <jgross@...e.com>,
	"H . Peter Anvin" <hpa@...or.com>,
	Dave Hansen <dave.hansen@...el.com>, Xin Li <xin@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 00/20] x86 MSR in-kernel API type cleanup and rename

On Wed, Apr 09, 2025 at 10:28:47PM +0200, Ingo Molnar wrote:

> Ingo Molnar (20):
>   x86/msr: Standardize on u64 in <asm/msr.h>
>   x86/msr: Standardize on u64 in <asm/msr-index.h>
>   x86/msr: Use u64 in rdmsrl_amd_safe() and wrmsrl_amd_safe()
>   x86/msr: Use u64 in rdmsrl_safe() and paravirt_read_pmc()
>   x86/msr: Harmonize the prototype and definition of do_trace_rdpmc()
>   x86/msr: Standardize on 'u32' MSR indices in <asm/msr.h>

Yay, thanks!

>   x86/msr: Rename 'rdmsrl()' to 'rdmsrq()'
>   x86/msr: Rename 'wrmsrl()' to 'wrmsrq()'
>   x86/msr: Rename 'rdmsrl_safe()' to 'rdmsrq_safe()'
>   x86/msr: Rename 'wrmsrl_safe()' to 'wrmsrq_safe()'
>   x86/msr: Rename 'rdmsrl_safe_on_cpu()' to 'rdmsrq_safe_on_cpu()'
>   x86/msr: Rename 'wrmsrl_safe_on_cpu()' to 'wrmsrq_safe_on_cpu()'
>   x86/msr: Rename 'rdmsrl_on_cpu()' to 'rdmsrq_on_cpu()'
>   x86/msr: Rename 'wrmsrl_on_cpu()' to 'wrmsrq_on_cpu()'
>   x86/msr: Rename 'mce_rdmsrl()' to 'mce_rdmsrq()'
>   x86/msr: Rename 'mce_wrmsrl()' to 'mce_wrmsrq()'
>   x86/msr: Rename 'rdmsrl_amd_safe()' to 'rdmsrq_amd_safe()'
>   x86/msr: Rename 'wrmsrl_amd_safe()' to 'wrmsrq_amd_safe()'
>   x86/msr: Rename 'native_wrmsrl()' to 'native_wrmsrq()'
>   x86/msr: Rename 'wrmsrl_cstar()' to 'wrmsrq_cstar()'

I'm so going to be typo-ing this for a while, but yeah, I suppose these
are better names.

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>