linux-kernel - Re: [PATCH] HID: HID_APPLETB_BL and HID_APPLETB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB9597163E40F42312B693C649B8B72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 10 Apr 2025 08:14:11 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
	Kerem Karabay <kekrby@...il.com>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on
 X86



> On 10 Apr 2025, at 1:39 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> 
> Hi Aditya,
> 
>> On Wed, 9 Apr 2025 at 16:35, Aditya Garg <gargaditya08@...e.com> wrote:
>>> On 09-04-2025 02:51 pm, Geert Uytterhoeven wrote:
>>> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
>>> dependency on X86, to prevent asking the user about this driver when
>>> configuring a kernel for a different architecture.
>>> 
>>> Fixes: 1fd41e5e3d7cc556 ("HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars")
>>> Fixes: 93a0fc48948107e0 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")
>> 
>> Nit:
>> 
>> The commit SHA should have only the first 12 characters.
>> 
>> https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
> 
> "at least the first 12 characters"

Ah interesting. I remember being ranted by some kernel dev about this before. Didn't know it changed.
> (I know, because I made that change lately ;-)
> 
>> Also, hid-appletb-kbd fix should be:
>> 
>> Fixes: 8e9b9152cfbd ("HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars")
>> 
>> I would also prefer having them as 2 separate patches.
> 
> OK, will do.
> 
Thanks

> Gr{oetje,eeting}s,
> 
>                        Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                -- Linus Torvalds