linux-kernel - Re: [PATCH v6 04/12] pwm: max7360: Add MAX7360 PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D92TURINAJOL.3ADIZ21U2DHCT@bootlin.com>
Date: Thu, 10 Apr 2025 10:48:38 +0200
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@...tlin.com>
To: "Andy Shevchenko" <andriy.shevchenko@...el.com>
Cc: "Lee Jones" <lee@...nel.org>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Kamel Bouhara" <kamel.bouhara@...tlin.com>, "Linus
 Walleij" <linus.walleij@...aro.org>, "Bartosz Golaszewski" <brgl@...ev.pl>,
 "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
 Uwe Kleine-König <ukleinek@...nel.org>, "Michael Walle"
 <mwalle@...nel.org>, "Mark Brown" <broonie@...nel.org>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, "Danilo Krummrich" <dakr@...nel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-gpio@...r.kernel.org>, <linux-input@...r.kernel.org>,
 <linux-pwm@...r.kernel.org>, Grégory Clement
 <gregory.clement@...tlin.com>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v6 04/12] pwm: max7360: Add MAX7360 PWM support

On Wed Apr 9, 2025 at 7:00 PM CEST, Andy Shevchenko wrote:
> On Wed, Apr 09, 2025 at 04:55:51PM +0200, mathieu.dubois-briand@...tlin.com wrote:
>> From: Kamel Bouhara <kamel.bouhara@...tlin.com>
>> 
>> Add driver for Maxim Integrated MAX7360 PWM controller, supporting up to
>> 8 independent PWM outputs.
>
> ...
>
>> +static void max7360_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
>> +{
>> +	struct regmap *regmap;
>> +	struct device *dev;
>> +
>> +	regmap = pwmchip_get_drvdata(chip);
>> +	dev = regmap_get_device(regmap);
>> +}
>
> This will produce compiler warnings. Why do you have this at all?

Some leftover of a previous version, having this clearly does not make
any sense. I'm surprised I didn't get any compiler warning about this.

>
> ...
>
>> +	device_set_of_node_from_dev(dev, dev->parent);
>
> This needs broader discussion.

Yes, we can continue our discussion in the pinctrl thread.

Ok with all other comments. Thanks for your review.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com